Restore stopped state if goto errors #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: A debug adapter can respond to goto with an error - e.g. if attempting to jump to a location where there is no code to execute. If that happened, selecting another goto location was no longer possible because the stopped state had been cleared. Solution: Restore stopped state if goto fails
mfussenegger
force-pushed
the
goto-errors
branch
from
1c3d20f
to
a92ee2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
A debug adapter can respond to goto with an error - e.g. if attempting
to jump to a location where there is no code to execute.
If that happened, selecting another goto location was no longer possible
because the stopped state had been cleared.
Solution:
Restore stopped state if goto fails