Update applyMiddleware to return #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for the PR. Good catch--definitely want to merge this in. Any chance you could write / modify a quick test to prevent this from potentially regressing in the future? |
|
@mhamann Added, let me know if you want me to change anything |
Hello!
I noticed a bug in this library where if you use an async route which returns, it does not finish the request. For example, using `applyMiddeware` with this function does not work:
```
module.exports = async (req, res) => {
return 'Ready!'
}
```
However, this does:
```
module.exports = (req, res) => {
res.end('Ready!')
}
```
Adding a `return` will ensure that both methods will work.
|
Merged and published as v1.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I noticed a bug in this library where if you use an async route which returns, it does not finish the request. For example, using
applyMiddewarewith this function does not work:However, this does:
Adding a
returnwill ensure that both methods will work.