Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow no additional files #4

Merged
merged 5 commits into from
Jul 15, 2022
Merged

Allow no additional files #4

merged 5 commits into from
Jul 15, 2022

Conversation

MuellerSeb
Copy link
Member

@MuellerSeb MuellerSeb commented Jul 15, 2022 •
edited
Loading

mask, gauge, gridfiles and ncfiles were stated as optional in the documentation, but basinex threw an error if they were not given.
This pull request fixes this.

@MuellerSeb MuellerSeb requested a review from pallavhydro July 15, 2022 12:43
pallavhydro
pallavhydro approved these changes Jul 15, 2022
View reviewed changes
Copy link
Collaborator

@pallavhydro pallavhydro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally. Commented mask: gridfiles: ncfiles:, and it works as it should.

@MuellerSeb MuellerSeb merged commit 446e6d3 into main Jul 15, 2022
@MuellerSeb MuellerSeb deleted the allow_no_additional_files branch July 15, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pallavhydro pallavhydro pallavhydro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MuellerSeb @pallavhydro