Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show formatted numbers in the paging when over 1,000 pages #307

Closed
mgpGit-zz opened this issue Jun 24, 2019 · 2 comments
Closed

Show formatted numbers in the paging when over 1,000 pages #307

mgpGit-zz opened this issue Jun 24, 2019 · 2 comments

Comments

@mgpGit-zz
Copy link

Angular version:
5.2.11

ngx-pagination version:
3.2.1

Description of issue:
The paging numbers do not have commas in it when the number of pages go past 1,000.
So the number displays as 4300 instead of 4,300.
(We use Server-Side Paging in our app so the number of pages can be large)

Steps to reproduce:
Set the totalItems to be a large number like 20,000 and make the itemsPerPage to be 5.

Expected result:
Show commas in the button page links for easy reading

Actual result:
The pages displayed in the button selection will not have commas in the number.

Demo:
Here is a demo
https://angular-upmtxc.stackblitz.io

Any relevant code:


@michaelbromley
Copy link
Owner

This would be a good enhancement. It could be done with the the built-n Angular number pipe in this part of the template.

I've not got time to do this right now, but I'll mark it as a good first issue and see if anyone wants to tackle it before I get round to it.

In the meantime if you really need this formatting right now, you'd have to use a custom template.

@michaelbromley
Copy link
Owner

Fixed by #309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants