Fix TensorPrimitives.IndexOfXx corner-case when first element is seed…

… value (dotnet#93169) * Fix TensorPrimitives.IndexOfXx corner-case when first element is seed value Found as part of adding more tests for Min/Max{Magnitude} to validate they match their IndexOfXx variants. * Address PR feedback
michaelgsharp · Oct 20, 2023 · fffa1d4 · fffa1d4
1 parent cd02aa5
commit fffa1d4
Show file tree

Hide file tree

Showing 2 changed files with 195 additions and 107 deletions.
diff --git a/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/TensorPrimitives.cs b/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/TensorPrimitives.cs
@@ -320,6 +320,7 @@ public static int IndexOfMax(ReadOnlySpan<float> x)
 
             if (!x.IsEmpty)
             {
+                result = 0;
                 float max = float.NegativeInfinity;
 
                 for (int i = 0; i < x.Length; i++)
@@ -370,6 +371,7 @@ public static int IndexOfMaxMagnitude(ReadOnlySpan<float> x)
 
             if (!x.IsEmpty)
             {
+                result = 0;
                 float max = float.NegativeInfinity;
                 float maxMag = float.NegativeInfinity;
 
@@ -423,6 +425,7 @@ public static int IndexOfMin(ReadOnlySpan<float> x)
 
             if (!x.IsEmpty)
             {
+                result = 0;
                 float min = float.PositiveInfinity;
 
                 for (int i = 0; i < x.Length; i++)
@@ -473,6 +476,7 @@ public static int IndexOfMinMagnitude(ReadOnlySpan<float> x)
 
             if (!x.IsEmpty)
             {
+                result = 0;
                 float min = float.PositiveInfinity;
                 float minMag = float.PositiveInfinity;