Support disabling both systemd and initd when installing from tarball. #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recipes/tarball.rb
Outdated
| @@ -177,7 +177,7 @@ | |||
| only_if { ::File.readlines('/etc/pam.d/su').grep(/# #{pam_limits}/).any? } | |||
| end | |||
|
|
|||
| if node['cassandra']['use_systemd'] == false | |||
| if node['cassandra']['use_initd'] == true | |||
There was a problem hiding this comment.
I've missed this in the original version, let's make this node['cassandra']['use_initd'].
There was a problem hiding this comment.
It is already use_initd, can you explain your comment?
There was a problem hiding this comment.
An explicit comparison with true is excessive and looks weird in Ruby. Any value other than false or nil evaluates to true.
recipes/tarball.rb
Outdated
| @@ -186,7 +186,7 @@ | |||
| mode '0755' | |||
| notifies :restart, 'service[cassandra]', :delayed if node['cassandra']['notify_restart'] | |||
| end | |||
| else | |||
| elseif node['cassandra']['use_systemd'] == true | |||
|
@michaelklishin - can you accept this PR? |
|
Now I can, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for omnibus installations. by default omnibus uses runit as service management.