Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons: update state cleanups #2258

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Conversation

3v1n0
Copy link
Collaborator

@3v1n0 3v1n0 commented Aug 5, 2024

Make possible to theme updating icons and avoid actions to be available during that phase.

@3v1n0 3v1n0 requested a review from sergio-costas August 5, 2024 22:47
@3v1n0 3v1n0 force-pushed the updating-cleanups branch from 0aa9793 to 7db8fa3 Compare August 6, 2024 03:16
@3v1n0
Copy link
Collaborator Author

3v1n0 commented Aug 6, 2024

Oh, I see Sergio is going to be out for some days, so @vanvugt can you maybe give it a quick check?

Or I'll just merge it so that I can unblock GNOME shell 47 landing.

@vanvugt vanvugt self-requested a review August 7, 2024 06:50
Copy link
Collaborator

@vanvugt vanvugt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, but I'm no expert on this code.

@vanvugt vanvugt merged commit a5c3a24 into micheleg:master Aug 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants