Progress bar theming tuning #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergio-costas
approved these changes
Aug 30, 2024
Let's handle unset values as undefined, as we should do
Don't use normal padding property here because we want the padding to be proportional to the icons sizes
That includes the search results and the app folders contents
3v1n0
force-pushed
the
progress-bar-theming-tuning
branch
2 times, most recently
from
1095cd7 to
d42c16a
Compare
Only create the label and items if we are showing stuff, otherwise it's just a waste. Also update it on scale factor changes
3v1n0
force-pushed
the
progress-bar-theming-tuning
branch
from
d42c16a to
446a75d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move progress bar on icon baseline on overview and permit tuning their positioning and size better via style variables.
This is following the upstream theme, while for yaru some further customization will be done