Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Action tip for both named and unnamed commands #1

Merged
merged 4 commits into from
Feb 28, 2021

Conversation

mickelsonmichael
Copy link
Owner

Based on tschaub#368 but required a re-creation of the PR to complete. For additional information please reference tschaub#368

The tip should lay out how to correctly configure a step to deploy an application via Github Actions. See issue tschaub#345 for more details
The hard-coded repository name can be replaced with the use
of the GITHUB_REPOSITORY environmental variable available
to the runner by default. The GitHub Actions tip has been
updated to reflect this feature.
When executing the gh-pages command via a script
defined inside the packages.json file, it requires
the addition of an `--` parameter to properly pass
the user information into the `gh-pages` command.
A new example has been added reflecting that advice.

This commit also includes minor formatting fixes and
improvements the the existing GitHub Actions example.
@mickelsonmichael mickelsonmichael merged commit 18d152b into main Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant