Store enum values as strings #11160
Merged
Store enum values as strings #11160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstepanov
force-pushed
the
dontstoreenums
branch
from
0a7f4d1 to
eb30f20
Compare
dstepanov
force-pushed
the
dontstoreenums
branch
from
eb30f20 to
ff900d0
Compare
|
can this be back ported to 4.6.x? |
|
I targeted a wrong branch |
graemerocher
approved these changes
Sep 6, 2024
|
some tests are failing |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this was fixed before, but it's still broken for manually added annotations / values