Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore any errors when getting jrt provider #11166

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Ignore any errors when getting jrt provider #11166

merged 2 commits into from
Sep 9, 2024

Conversation

dstepanov
Copy link
Contributor

Fixes #11152

burtbeckwith
burtbeckwith reviewed Sep 8, 2024
View reviewed changes
core/src/main/java/io/micronaut/core/io/service/ServiceScanner.java Outdated
if (fs.isOpen()) {
return fs;
}
} catch (Exception e) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to catch Throwable here, ServiceLoader.fail() throws ServiceConfigurationError

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW I wasn't able to reproduce it. Is there something special in your case?

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
55.2% Coverage on New Code (required ≥ 70%)
1 New Bugs (required ≤ 0)
1 New Blocker Issues (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@graemerocher graemerocher merged commit dba1492 into 4.6.x Sep 9, 2024
20 of 21 checks passed
@graemerocher graemerocher deleted the grprov branch September 9, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burtbeckwith burtbeckwith burtbeckwith left review comments

@graemerocher graemerocher graemerocher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
4.6.2 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dstepanov @graemerocher @burtbeckwith