-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Json Schema Generator Plugin #1067
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great work! I have added a few minor comments but this is already in a pretty good shape, congrats!
jsonschema-plugin/src/main/java/io/micronaut/gradle/jsonschema/DefaultJSONSchemaExtension.java
Outdated
Show resolved
Hide resolved
@@ -14,7 +14,7 @@ pluginManager.apply(io.micronaut.build.MicronautQualityChecksParticipantPlugin) | |||
repositories { | |||
mavenCentral() | |||
gradlePluginPortal() | |||
// maven { url = uri("https://s01.oss.sonatype.org/content/repositories/snapshots/") } | |||
maven { url = uri("https://s01.oss.sonatype.org/content/repositories/snapshots/") } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be removed before merging
gradle/libs.versions.toml
Outdated
@@ -17,6 +17,7 @@ micronaut-platform = "4.7.4" # This is the platform version, used in our tests | |||
micronaut-aot = "2.6.0" | |||
micronaut-testresources = "2.7.2" | |||
micronaut-openapi = "6.13.2" | |||
micronaut-jsonschema = "1.3.1-SNAPSHOT" # TODO: update to include new generation plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix before merging
class JsonSchemaGeneratorSpec extends AbstractGradleBuildSpec{ | ||
def "can generate source code from URL"() { | ||
given: | ||
allowSnapshots = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be changed before merging
jsonschema-plugin/src/test/groovy/io/micronaut/gradle/jsonschema/JsonSchemaGeneratorSpec.groovy
Outdated
Show resolved
Hide resolved
jsonschema-plugin/src/test/groovy/io/micronaut/gradle/jsonschema/JsonSchemaGeneratorSpec.groovy
Outdated
Show resolved
Hide resolved
jsonschema-plugin/src/test/groovy/io/micronaut/gradle/jsonschema/JsonSchemaGeneratorSpec.groovy
Outdated
Show resolved
Hide resolved
jsonschema-plugin/src/test/groovy/io/micronaut/gradle/jsonschema/JsonSchemaGeneratorSpec.groovy
Outdated
Show resolved
Hide resolved
@@ -2,6 +2,7 @@ pluginManagement { | |||
repositories { | |||
mavenCentral() | |||
gradlePluginPortal() | |||
maven { url = uri("https://s01.oss.sonatype.org/content/repositories/snapshots/") } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be removed before merging
Creating a plugin for the json-schema project's generator module.