Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Json Schema Generator Plugin #1067

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

elifKurtay
Copy link

Creating a plugin for the json-schema project's generator module.

@elifKurtay elifKurtay marked this pull request as ready for review January 20, 2025 14:44
@graemerocher graemerocher requested a review from melix January 20, 2025 15:39
Copy link
Collaborator

@melix melix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work! I have added a few minor comments but this is already in a pretty good shape, congrats!

@@ -14,7 +14,7 @@ pluginManager.apply(io.micronaut.build.MicronautQualityChecksParticipantPlugin)
repositories {
mavenCentral()
gradlePluginPortal()
// maven { url = uri("https://s01.oss.sonatype.org/content/repositories/snapshots/") }
maven { url = uri("https://s01.oss.sonatype.org/content/repositories/snapshots/") }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed before merging

@@ -17,6 +17,7 @@ micronaut-platform = "4.7.4" # This is the platform version, used in our tests
micronaut-aot = "2.6.0"
micronaut-testresources = "2.7.2"
micronaut-openapi = "6.13.2"
micronaut-jsonschema = "1.3.1-SNAPSHOT" # TODO: update to include new generation plugin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix before merging

class JsonSchemaGeneratorSpec extends AbstractGradleBuildSpec{
def "can generate source code from URL"() {
given:
allowSnapshots = true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be changed before merging

@@ -2,6 +2,7 @@ pluginManagement {
repositories {
mavenCentral()
gradlePluginPortal()
maven { url = uri("https://s01.oss.sonatype.org/content/repositories/snapshots/") }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed before merging

@andriy-dmytruk andriy-dmytruk self-requested a review January 21, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants