fix: mn create fails since 4.3.0 #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 4.3.0 when we added chatbot creation, we abstracted the builder commands away. At one point, we combine application-type features and user specified features into a single set. The issue here is that the set in the case of the create command was unmodifiable. This then failed with the esoteric 'Error null' message. This PR takes the features from the application type, and loads them into a HashSet prior to doing any manipulation. I did it this way as it's hard to test this area of the functionality, and it will prevent us having a similar issue if we add further commands Closes #2318
sdelamo
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 4.3.0 when we added chatbot creation, we abstracted the builder commands away.
At one point, we combine application-type features and user specified features into a single set.
The issue here is that the set in the case of the create command was unmodifiable.
This then failed with the esoteric 'Error null' message.
This PR takes the features from the application type, and loads them into a HashSet prior to doing any manipulation.
I did it this way as it's hard to test this area of the functionality, and it will prevent us having a similar issue if we add further commands
Closes #2318