-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add micronaut-json-schema feature. #2432
Conversation
ping @sdelamo Should this support all application types? |
Yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove JsonSchemaConfiguration
. I think we may change the base uri to http.//localhost:8080/schemas
.
Create an extra feature to add json-schema-validation module to the test class path.
Add static-resources configuration to expose the features.
@sdelamo What kind of logic do you want for adding one and/or the other, or validating the presence of them?
Edit: I did what's checked. Can make changes if desired. |
starter-core/src/main/java/io/micronaut/starter/feature/json/JsonSchemaFeature.java
Outdated
Show resolved
Hide resolved
starter-core/src/main/java/io/micronaut/starter/feature/json/JsonSchemaValidationFeature.java
Show resolved
Hide resolved
...re/src/main/java/io/micronaut/starter/feature/json/JsonSchemaValidationFeatureValidator.java
Outdated
Show resolved
Hide resolved
CI is failing on Edit: see #2435 |
ping @sdelamo I merged the |
Let's wait until we have a release of Micronaut JSON Schema. |
closes #2431
This needs to target 4.5.x once that branch is created