Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add micronaut-json-schema feature. #2432

Merged
merged 9 commits into from
Jun 1, 2024
Merged

Conversation

wetted
Copy link
Contributor

@wetted wetted commented Apr 9, 2024

closes #2431

This needs to target 4.5.x once that branch is created

@wetted wetted added the type: enhancement New feature or request label Apr 9, 2024
@wetted wetted self-assigned this Apr 9, 2024
@wetted
Copy link
Contributor Author

wetted commented Apr 9, 2024

ping @sdelamo Should this support all application types?

@sdelamo
Copy link
Contributor

sdelamo commented Apr 10, 2024

ping @sdelamo Should this support all application types?

Yes.

Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove JsonSchemaConfiguration. I think we may change the base uri to http.//localhost:8080/schemas.

Create an extra feature to add json-schema-validation module to the test class path.

Add static-resources configuration to expose the features.

@wetted
Copy link
Contributor Author

wetted commented Apr 10, 2024

Create an extra feature to add json-schema-validation module to the test class path.

@sdelamo What kind of logic do you want for adding one and/or the other, or validating the presence of them?

  • add json-schema-validator feature if not present when selecting json-schema feature?
  • FeatureValidator to assert json-schema is present if json-schema-validator is selected?
  • something else?

Edit: I did what's checked. Can make changes if desired.

@wetted wetted marked this pull request as ready for review April 10, 2024 17:45
@wetted wetted requested a review from sdelamo April 10, 2024 17:45
@wetted wetted requested a review from sdelamo April 11, 2024 14:36
@wetted
Copy link
Contributor Author

wetted commented Apr 11, 2024

CI is failing on :test-features:test because ThymeleafSpec generates a project with views-fieldset-tck, and the TCK test fails. I'll see if I can figure it out.

Edit: see #2435

@wetted
Copy link
Contributor Author

wetted commented Apr 12, 2024

ping @sdelamo I merged the ThymeleafSpec fix and CI is green now. This should be GTG.

@sdelamo sdelamo changed the base branch from 4.4.x to 4.5.x April 18, 2024 05:38
@sdelamo sdelamo marked this pull request as draft April 18, 2024 09:52
@sdelamo
Copy link
Contributor

sdelamo commented Apr 18, 2024

ping @sdelamo I merged the ThymeleafSpec fix and CI is green now. This should be GTG.

Let's wait until we have a release of Micronaut JSON Schema.

@graemerocher graemerocher marked this pull request as ready for review May 31, 2024 06:56
@graemerocher graemerocher merged commit a61c204 into 4.5.x Jun 1, 2024
13 checks passed
@graemerocher graemerocher deleted the jason-schema-feature branch June 1, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Features for JSON Schema
3 participants