Fix Maven/Groovy builds with zipkin and jaeger #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had an api dependency on micronaut-core-processor which meant it was ending up on the runtime classpath. This was fixed here micronaut-projects/micronaut-tracing#553 (comment) However for Maven and Groovy this causes a failure as it no longer ends up getting pulled onto the provided configuration. Once this fix is released, we can remove the skips from the jaeger and zipkin guides here: micronaut-projects/micronaut-guides@798040a#diff-429b78dd62241a22ac3b663ca2d045441a9326121c3b6bbf19f5859d94c2e3d8
sdelamo
approved these changes
May 8, 2024
|
@timyates create a draft PR in guides reverting the skips |
timyates
added a commit
to micronaut-projects/micronaut-guides
that referenced
this pull request
May 8, 2024
Once 4.4.3 is out with micronaut-projects/micronaut-starter#2483 we can resume the maven/groovy guides
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an api dependency on micronaut-core-processor which meant it was ending up on the runtime classpath.
This was fixed here
micronaut-projects/micronaut-tracing#553 (comment)
However for Maven and Groovy this causes a failure as it no longer ends up getting pulled onto the provided configuration.
Once this fix is released, we can remove the skips from the jaeger and zipkin guides here:
micronaut-projects/micronaut-guides@798040a#diff-429b78dd62241a22ac3b663ca2d045441a9326121c3b6bbf19f5859d94c2e3d8