Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply JUL to Slf4j for liquibase automatically #2623

Merged
merged 7 commits into from
Nov 8, 2024
Merged

Apply JUL to Slf4j for liquibase automatically #2623

merged 7 commits into from
Nov 8, 2024

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Oct 1, 2024

Apply JUL to Slf4j for liquibase automatically

  • add liquibase-slf4j feature
  • don’t define versions for slf4j and jul-to-slf4j They are defined in micronaut-logging BOM
  • Extract MicronautDependencyUtils::elasticSearchDependency
  • when jul-to-slf4j is added modify Application.java|kt|groovy and add:
SLF4JBridgeHandler.removeHandlersForRootLogger();
SLF4JBridgeHandler.install();

see: https://stackoverflow.com/a/9117188

- don’t define versions for slf4j and jul-to-slf4j They are defined in micronaut-logging BOM
- Extract `MicronautDependencyUtils::elasticSearchDependency`
- when jul-to-slf4j is added modify Application.java and add:

```java
SLF4JBridgeHandler.removeHandlersForRootLogger();
SLF4JBridgeHandler.install();
```
@sdelamo sdelamo requested review from melix, yawkat and burtbeckwith and removed request for melix October 1, 2024 13:39
@sdelamo sdelamo added the type: improvement A minor improvement to an existing feature label Oct 1, 2024
@sdelamo sdelamo merged commit 95bedb7 into 4.7.x Nov 8, 2024
12 of 14 checks passed
@sdelamo sdelamo deleted the jul-logging branch November 8, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement A minor improvement to an existing feature
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants