Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ON HOLD][Shopify] Shopify allow use of customer creation and update #24967

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[ON HOLD][Shopify] Shopify allow use of customer creation and update #24967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions Apps/W1/Shopify/app/src/Customer/Codeunits/ShpfyCreateCustomer.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
/// </summary>
codeunit 30110 "Shpfy Create Customer"
{
Access = Internal;
Permissions =
#if not CLEAN22
tabledata "Config. Template Header" = r,
Expand Down Expand Up @@ -171,7 +170,7 @@ codeunit 30110 "Shpfy Create Customer"
/// Set Shop.
/// </summary>
/// <param name="Code">Parameter of type Code[20].</param>
internal procedure SetShop(Code: Code[20])
procedure SetShop(Code: Code[20])
begin
Clear(Shop);
Shop.Get(Code);
Expand All @@ -181,7 +180,7 @@ codeunit 30110 "Shpfy Create Customer"
/// Set Shop.
/// </summary>
/// <param name="ShopifyShop">Parameter of type Record "Shopify Shop".</param>
internal procedure SetShop(ShopifyShop: Record "Shpfy Shop")
procedure SetShop(ShopifyShop: Record "Shpfy Shop")
begin
Shop := ShopifyShop;
end;
Expand All @@ -190,7 +189,7 @@ codeunit 30110 "Shpfy Create Customer"
/// Set Template Code.
/// </summary>
/// <param name="Code">Parameter of type Code[20].</param>
internal procedure SetTemplateCode(Code: Code[20])
procedure SetTemplateCode(Code: Code[20])
begin
TemplateCode := Code;
end;
Expand Down
16 changes: 7 additions & 9 deletions Apps/W1/Shopify/app/src/Customer/Codeunits/ShpfyCustomerImport.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
/// </summary>
codeunit 30117 "Shpfy Customer Import"
{
Access = Internal;

trigger OnRun()
var
CustomerAddress: Record "Shpfy Customer Address";
Expand Down Expand Up @@ -49,12 +47,12 @@ codeunit 30117 "Shpfy Customer Import"
/// Get Customer.
/// </summary>
/// <param name="ShopifyCustomerResult">Parameter of type Record "Shopify Customer".</param>
internal procedure GetCustomer(var ShopifyCustomerResult: Record "Shpfy Customer")
procedure GetCustomer(var ShopifyCustomerResult: Record "Shpfy Customer")
begin
ShopifyCustomerResult := ShopifyCustomer;
end;

internal procedure SetAllowCreate(Value: Boolean)
procedure SetAllowCreate(Value: Boolean)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should have a good documentation for all procedures that aren't marked as internal.

begin
AllowCreate := Value;
end;
Expand All @@ -63,7 +61,7 @@ codeunit 30117 "Shpfy Customer Import"
/// Set Customer.
/// </summary>
/// <param name="Id">Parameter of type BigInteger.</param>
internal procedure SetCustomer(Id: BigInteger)
procedure SetCustomer(Id: BigInteger)
begin
if Id <> 0 then begin
Clear(ShopifyCustomer);
Expand All @@ -82,7 +80,7 @@ codeunit 30117 "Shpfy Customer Import"
/// Set Customer.
/// </summary>
/// <param name="ShopifyCustomer">Parameter of type Record "Shopify Customer".</param>
internal procedure SetCustomer(ShopifyCustomer: Record "Shpfy Customer")
procedure SetCustomer(ShopifyCustomer: Record "Shpfy Customer")
begin
SetCustomer(ShopifyCustomer.Id);
end;
Expand All @@ -91,7 +89,7 @@ codeunit 30117 "Shpfy Customer Import"
/// Set Shop.
/// </summary>
/// <param name="Code">Parameter of type Code[20].</param>
internal procedure SetShop(Code: Code[20])
procedure SetShop(Code: Code[20])
begin
Clear(Shop);
Shop.Get(Code);
Expand All @@ -102,7 +100,7 @@ codeunit 30117 "Shpfy Customer Import"
/// Set Shop.
/// </summary>
/// <param name="ShopifyShop">Parameter of type Record "Shopify Shop".</param>
internal procedure SetShop(ShopifyShop: Record "Shpfy Shop")
procedure SetShop(ShopifyShop: Record "Shpfy Shop")
begin
Shop := ShopifyShop;
CustomerApi.SetShop(Shop);
Expand All @@ -112,7 +110,7 @@ codeunit 30117 "Shpfy Customer Import"
/// Set Template Code.
/// </summary>
/// <param name="Code">Parameter of type Code[10].</param>
internal procedure SetTemplateCode(Code: Code[10])
procedure SetTemplateCode(Code: Code[10])
begin
TemplateCode := Code;
end;
Expand Down
1 change: 0 additions & 1 deletion Apps/W1/Shopify/app/src/Customer/Codeunits/ShpfyUpdateCustomer.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
/// </summary>
codeunit 30124 "Shpfy Update Customer"
{
Access = Internal;
Permissions =
#if not CLEAN22
tabledata "Config. Template Header" = r,
Expand Down
Loading