-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Shopify] - Different Shipping Charges Types Tests #27575
[Shopify] - Different Shipping Charges Types Tests #27575
Conversation
Apps/W1/Shopify/test/Shipping/ShpfyShippingChargesTest.Codeunit.al
Outdated
Show resolved
Hide resolved
Internal run results in test failures: Error: Cannot find an overload for "GetEnumerator" and the argument count: "0". Item: Name: |
pushed fix, can you re-run the internal tests? @JesperSchulz |
Apps/W1/Shopify/test/Shipping/ShpfyShippingChargesTest.Codeunit.al
Outdated
Show resolved
Hide resolved
Still an internally failing test like above :-( The VAT Posting Setup does not exist. Identification fields and values: VAT Bus. Posting Group='SSAZUWBNNH',VAT Prod. Posting Group='VAT7' |
@JesperSchulz missed one place where we used the same pattern for GL Account. I've pushed fix for this issue. |
The test is still failing. Now with a slightly different message: [2024-11-28 16:01:27] Failed tests: |
@JesperSchulz pushed another fix, now it should be fine. Sorry for that it goes like this - it worked fine on our container all the time. It makes harder to find the issue. |
No worries! Let's try again :-) |
Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one. Build ID: 27531. |
This pull request does not have a related issue as it's part of the delivery for development agreed directly with @AndreiPanko
Different shipping charges types Tests
Automated tests for changes #26708
Fixes #26819
Fixes AB#556525