Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E-Document Core] - Show Purchase attachments in Peppol #27876

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

GMatuleviciute
Copy link

@GMatuleviciute GMatuleviciute commented Jan 3, 2025

This pull request does not have a related issue as it's part of delivery for development agreed directly with @altotovi @Groenbech96

Implementation

This update ensures that when a Peppol file with Purchase document which contains an embedded PDF is received, the system extracts the PDF and displays it in assigned Factbox as attachment. This feature allows users to access embedded PDF before creating Purchase documents like invoices, orders or credit memos.

A new Factbox 'Doc. Attachment List' is added to the following pages:
'E-Document' (Page 6121)
'E-Documents' (Page 6122)

@GMatuleviciute GMatuleviciute requested review from a team as code owners January 3, 2025 12:51
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link.

@GMatuleviciute
Copy link
Author

@microsoft-github-policy-service agree company="Companial"

@Groenbech96 Groenbech96 self-assigned this Jan 6, 2025
@Groenbech96 Groenbech96 added the Integration GitHub request for Integration area label Jan 6, 2025
Database::"E-Document":
begin
RecRef.Open(Database::"E-Document");
if EDocument.Get(DocumentAttachment."No.") then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the DocumentAttachment."No." really correct here?
Shouldn't it be DocumentAttachment."E-Document Entry No."?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If e-document has no linked document in the attachments table Table ID is equal to E-Document table id and No. is equal to Entry No.
E-Document:
image
Attachments table:
image
If e-document has linked document then attachment record is renamed to have a link with related document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration GitHub request for Integration area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants