Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for custom view tasks #3675

Merged
merged 3 commits into from
Apr 21, 2022
Merged

Fix for custom view tasks #3675

merged 3 commits into from
Apr 21, 2022

Conversation

kevinleung23
Copy link
Member

Fixes # N/A

Proposed Changes

The current examples do not work as the validDomains property in the Microsoft Teams manifest are missing. All other components of the messaging extension sample work other than the "Web View" and "Static HTML" options as they both require a fetch task.

  • Adding the required property to both JS and Python samples
    • Opted to include an ngrok wildcard as that is the technology suggested by the sample README

Testing

  • No new tests added. Sample now works out of the box

image

image

@kevinleung23 kevinleung23 requested a review from a team as a code owner January 12, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants