Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transcript navigation by arrow keys #3703

Merged
merged 66 commits into from
Feb 14, 2021

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Feb 3, 2021

Fixes #2996.

Changelog Entry

Added

  • Resolves #2996. Added transcript navigation by keyboard navigation keys, by @compulim in PR #3703

Description

When focused in the transcript, pressing UP, DOWN, HOME, END should activate different activities (via aria-activedescendant).

When focused in the send box, pressing PGUP, PGDN, HOME, END should scroll the transcript.

If "New messages" button appears, clicking on it should activate the next unread activity.

Design

(TBD)

Specific Changes

(TBD)

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@corinagum
Copy link
Contributor

@amal-khalaf is planning on adding a new section on Technical limitations. I think that would be a good place to add documentation on why we did not add Ctrl + Alt + Arrow. Thoughts?

CHANGELOG.md Outdated Show resolved Hide resolved
docs/HOOKS.md Outdated Show resolved Hide resolved
docs/HOOKS.md Outdated Show resolved Hide resolved
@compulim
Copy link
Contributor Author

compulim commented Feb 4, 2021

@amal-khalaf is planning on adding a new section on Technical limitations. I think that would be a good place to add documentation on why we did not add Ctrl + Alt + Arrow. Thoughts?

TBH, I am unsure if ALT is a good modifier key. But I prefer to stick to only one combo, so IMO, single ALT looks better to me than ALT + CTRL.

WhatsApp Web and Telegram use PGUP and PGDN and they are scrolling by ~80% of the page (i.e. offsetHeight * 0.8), not just a few lines. We use 40px because the browser I tested use this number for mouse wheel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Accessibility][Keyboard] - Message navigation is not available.
2 participants