Fix loading universal checkpoint for BF16_Optimizer #5211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR#5104 (Remove optimizer step on initialization) breaks loading universal checkpoint for BF16_Optimizer. This is since universal checkpoint attempts to load the optimizer states into lp._hp_mapping.optim_state dictionary before they are initialized (by step). As a workaround for loading universal checkpoint, perform step and init hp params optimizer's states before loading from universal checkpoint files. Signed-off-by: Moshe Island <[email protected]>
|
@misland-habana, I think we have fixed the underlying issue. Can you please check if this PR is still needed? Thanks. |
@tjruwase, sorry for the late reply (vacation...). I have re-tested with your fix for the underlying issue and it is working for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR#5104 (Remove optimizer step on initialization) breaks loading universal checkpoint for BF16_Optimizer.
This is since universal checkpoint attempts to load the optimizer states into lp._hp_mapping.optim_state dictionary before they are initialized (by step).
As a workaround for loading universal checkpoint, perform step and init hp params optimizer's states before loading from universal checkpoint files.