Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory fragmentation in x86 #235

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bugale
Copy link

@bugale bugale commented Apr 12, 2022

The method used to allocate trampolines in Detours does not avoid memory fragmentation, which is especially important on platforms where the virtual address space is scarce (like x86).

In this patch we try to minimize the effects of fragmentation by modifying the requested allocation address so that it will be adjacent to the next occupied memory block.

Without this patch, there is a slight chance that in the course of allocating a new trampoline, Detours will undeliberately split a large contiguous memory block into two smaller blocks, thus causing fragmentation.

The effects of fragmentation can be disastrous, since some applications tend to allocate large quantities of memory as part of their start-up code. In case a single block large enough to fulfill the allocation request cannot be found, these applications
will simply fail to start.

Microsoft Reviewers: Open in CodeFlow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants