-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[c++] update to fmt 11.1.2, fast_double_parser 0.8.0 #6802
base: master
Are you sure you want to change the base?
Conversation
The only compilation failure left is this one on Appveyor:
That code was JUST introduced into Note that that is failing with MSVC 2015... other builds with later MSVC versions do not have this compilation error, for example this one with Visual Studio 2019: https://github.com/microsoft/LightGBM/actions/runs/12981353281/job/36199682684?pr=6802 I'm going to try rolling back one minor version to |
/gha run r-valgrind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for doing this!
Contributes to #3763.
Contributes to #5691.
Proposes updated the projects vendored in here as git submodules to their latest versions:
boostorg/compute
: being worked on separately in [ci] update libboost version from1.74
to1.83
#6582fmtlib/fmt
: fromv10.1.1
(August 2023) tov11.1.2
(January 2025)11.1.3
? see [c++] update to fmt 11.1.2, fast_double_parser 0.8.0 #6802 (comment)lemire/fast_double_parser
: fromv0.7.0
(December 2022) tov0.8.0
(May 2024)libeigen/eigen
: no change (already on v3.4.0, August 2021)How I did that
Benefits of this change
Pulls in bugfixes, security patches, performance improvements.
The last update like this was #6074, over a year ago.