Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<deque>: _RERAISE -> scope guard #2308

Merged
merged 17 commits into from
Mar 28, 2022
Merged

<deque>: _RERAISE -> scope guard #2308

merged 17 commits into from
Mar 28, 2022

Conversation

AlexGuteniev
Copy link
Contributor

Towards #2307

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner October 30, 2021 09:37
miscco
miscco reviewed Oct 30, 2021
View reviewed changes
Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this. It makes the code so much cleaner and improves debug experience

stl/inc/deque Outdated Show resolved Hide resolved
stl/inc/deque Outdated Show resolved Hide resolved
stl/inc/deque Show resolved Hide resolved
tests/std/tests/GH_002307_usual_scope_guard/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/GH_002307_usual_scope_guard/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/GH_002307_usual_scope_guard/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/GH_002307_usual_scope_guard/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/GH_002307_usual_scope_guard/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/GH_002307_usual_scope_guard/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/GH_002307_usual_scope_guard/test.cpp Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Nov 1, 2021
@StephanTLavavej StephanTLavavej self-assigned this Nov 3, 2021
StephanTLavavej
StephanTLavavej requested changes Feb 23, 2022
View reviewed changes
tests/std/tests/GH_002307_usual_scope_guard/test.cpp Outdated Show resolved Hide resolved
stl/inc/deque Outdated Show resolved Hide resolved
tests/std/tests/GH_002307_usual_scope_guard/test.cpp Outdated Show resolved Hide resolved
stl/inc/deque Outdated Show resolved Hide resolved
tests/std/tests/GH_002307_usual_scope_guard/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/GH_002307_usual_scope_guard/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/GH_002307_usual_scope_guard/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/GH_002307_usual_scope_guard/test.cpp Outdated Show resolved Hide resolved
stl/inc/deque Outdated Show resolved Hide resolved
stl/inc/deque Show resolved Hide resolved
@StephanTLavavej StephanTLavavej removed their assignment Feb 23, 2022
@StephanTLavavej StephanTLavavej self-assigned this Feb 23, 2022
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
@StephanTLavavej StephanTLavavej removed their assignment Feb 24, 2022
@CaseyCarter CaseyCarter self-assigned this Mar 2, 2022
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
CaseyCarter
CaseyCarter approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll push changes for my nitpicky comments.

stl/inc/deque Outdated Show resolved Hide resolved
stl/inc/deque Show resolved Hide resolved
stl/inc/deque Show resolved Hide resolved
tests/std/tests/GH_002307_usual_scope_guard/test.cpp Outdated Show resolved Hide resolved
@CaseyCarter CaseyCarter removed their assignment Mar 21, 2022
@StephanTLavavej StephanTLavavej self-assigned this Mar 25, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 3b5d49b into microsoft:main Mar 28, 2022
@StephanTLavavej
Copy link
Member

Thanks for significantly improving the debugging experience here! 🎉 😻 😸

@AlexGuteniev AlexGuteniev deleted the usual_scope_guards branch March 29, 2022 04:31
@AlexGuteniev AlexGuteniev mentioned this pull request Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@miscco miscco miscco left review comments

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexGuteniev @StephanTLavavej @CaseyCarter @miscco