Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make invoke constexpr available in all modes #4134

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

grcm10
Copy link
Contributor

@grcm10 grcm10 commented Oct 29, 2023

Resolves #4080 by replacing the _CONSTEXPR17 with constexpr for std::invoke.

@grcm10 grcm10 requested a review from a team as a code owner October 29, 2023 14:11
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Oct 30, 2023
@StephanTLavavej
Copy link
Member

Thanks! I pushed comment changes and I believe this needs only one maintainer approval.

@StephanTLavavej StephanTLavavej self-assigned this Nov 6, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit a34519b into microsoft:main Nov 7, 2023
@StephanTLavavej
Copy link
Member

Thanks for improving invoke's usability even in the ancient past of C++14! 📆 🎉 😸

@grcm10 grcm10 deleted the invokeconstexpr branch November 12, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we make invoke constexpr in all modes?
3 participants