Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized string concatenation in _Tzdb_update_version() #4577

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Optimized string concatenation in _Tzdb_update_version() #4577

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbc7d9e
Remove meaningless std::move.Optimized string concatenation.
Mq-b Apr 11, 2024
ba05445
Modify the return problem
Mq-b Apr 11, 2024
737bba9
Use separate statements for concatenation.
StephanTLavavej Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion stl/inc/chrono
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2176,7 +2176,9 @@ namespace chrono {

_NODISCARD inline string _Tzdb_update_version(const string_view _Version, const size_t _Num_leap_seconds) {
string _Icu_version{_Version.substr(0, _Version.find_last_of('.'))};
return _STD move(_Icu_version) + "." + _STD to_string(_Num_leap_seconds);
_Icu_version += '.';
_Icu_version += _STD to_string(_Num_leap_seconds);
return _Icu_version;
}

struct _Secret_tzdb_list_construct_tag {
Expand Down