<regex>
: Silence CodeQL false positive warning
#5072
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows encountered internal OS-50456631 "[CodeQL:Warning]: SM02323: cpp/infiniteloop (in packages/[...]/regex)", reported to me by @DefaultRyan. According to the internal doc, this is:
In this case, the warning is a false positive, and my suppression comment explains why.
Alternatively, we could widen the
unsigned int
tosize_t
, either with astatic_cast
or a named variable, but that'd be unusual enough to still merit a comment, so I chose the less invasive approach.