Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript Issue # 18615. #299

Merged
merged 8 commits into from
Jan 8, 2018
Merged

Conversation

muj-beg
Copy link
Contributor

@muj-beg muj-beg commented Sep 24, 2017

Added DOMRect, DOMRectReadOnly and DOMRectList types. Modified signatures of properties/methods that used ClientRect or ClintRectList types to use ClientRect | DOMRect or ClintRectList | DOMRectList types respectively. (Left some MS/IE/Edge specific methods/properties unchanged)

@HolgerJeromin
Copy link
Contributor

ref microsoft/TypeScript#18615

@mhegazy
Copy link
Contributor

mhegazy commented Oct 16, 2017

@muj-beg can you please refresh this PR.

@muj-beg
Copy link
Contributor Author

muj-beg commented Oct 20, 2017

@mhegazy PR updated.

@saschanaz
Copy link
Contributor

Tip: git pull --rebase Microsoft master is great!

@timocov
Copy link
Contributor

timocov commented Nov 1, 2017

@muj-beg why added interfaces is without "flavor": "DOM" property? Seems that is DOM-only types.

# Conflicts:
#	baselines/dom.generated.d.ts
#	inputfiles/addedTypes.json
#	inputfiles/overridingTypes.json
@muj-beg
Copy link
Contributor Author

muj-beg commented Dec 3, 2017

@timocov I've added the flavor: DOM to these and merged in latest changes.
(Sorry, my merge history is a mess -- I realize I should have done a rebase. I'll keep that in mind for next time.)

@mhegazy mhegazy closed this Jan 8, 2018
@mhegazy mhegazy reopened this Jan 8, 2018
@mhegazy mhegazy merged commit 945e4c5 into microsoft:master Jan 8, 2018
nscarcella added a commit to nscarcella/TypeScript-DOM-lib-generator that referenced this pull request Sep 29, 2023
@nscarcella nscarcella mentioned this pull request Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants