Restore FileReaderProgressEvent #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type doesn't exist, but is useful until we parametrise ProgressEvent with subtype properties. Fixes microsoft/TypeScript#25510
|
@saschanaz You might be interested in this one. |
|
@andrewbranch @rbuckton I'm adding you as reviewers so that somebody else on the team is aware of TSJS-lib-generator changes. |
|
Well, why not just parameterize it? |
andrewbranch
approved these changes
Jun 4, 2019
| @@ -153,7 +153,7 @@ export function emitWebIdl(webidl: Browser.WebIdl, flavor: Flavor) { | |||
| /// Interface name to its related eventhandler name list map | |||
| /// Note: | |||
| /// In the xml file, each event handler has | |||
| /// 1. eventhanlder name: "onready", "onabort" etc. | |||
| /// 1. eventhandler name: "onready", "onabort" etc. | |||
|
@saschanaz This is easier for now until I understand the compatibility concerns of parametrising ProgressEvent. This definitely works the way people expect because that's the way it used to work. |
saschanaz
added a commit
to saschanaz/types-web
that referenced
this pull request
Jun 5, 2019
This reverts commit 17d343a.
saschanaz
added a commit
to saschanaz/types-web
that referenced
this pull request
Jun 5, 2019
This reverts commit 17d343a.
|
What is meant by "parametrise ProgressEvent with subtype properties"? Making it into a discriminated union or something...? |
saschanaz
added a commit
to saschanaz/types-web
that referenced
this pull request
Jun 5, 2019
This reverts commit 17d343a.
|
@fatcerberus See #707 for @saschanaz' implementation. I was thinking of a general way to add properties, but #707 is sensibly much more restricted. It just lets subtypes change the type of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type doesn't exist, but it did before about a year ago, and is useful until we parametrise ProgressEvent with subtype properties.
Also fixes variable names in
merge, which had source and target backward, making for some confusing reading.Fixes microsoft/TypeScript#25510