Run jake in interactive mode so output isn't lost. #2048
Conversation
|
Hi @jbondc, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
| @@ -476,6 +469,8 @@ desc("Builds the test infrastructure using the built compiler"); | |||
| task("tests", ["local", run].concat(libraryTargets)); | |||
|
|
|||
| function exec(cmd, completeHandler) { | |||
|
|
|||
| return; | |||
There was a problem hiding this comment.
Doesn't seem right, accidentally committed test code?
There was a problem hiding this comment.
What is this return for? Should we just eliminate this function if we don't need it anymore?
|
What effect does this have? |
|
Oops the 'return' was accidental. I'll add 'interactive' to exec() as well. |
|
Ahh, looks like it uncovered two bugs :) (a) Third argument: syntacticClassifierAbsent: boolean ? |
|
@DanielRosenwasser is looking into syntacticClassifierAbsent |
|
We've decided that this parameter should no longer be optional. #2051. |
| var ex = jake.createExec([cmd]); | ||
| ex.addListener("cmdEnd", function() { | ||
|
|
||
| exec(cmd, function() { |
There was a problem hiding this comment.
Indent back a a level (i.e. this should only be 4 spaces from the beginning-of-line)
|
Try pulling in recent changes and update the PR. |
Fix jake perftsc
|
Reopened in another pull request, no idea why build is failing. |
No description provided.