Normalize type references before relating them #35266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@typescript-bot test this |
|
Heya @ahejlsberg, I've started to run the perf test suite on this PR at c73affd. You can monitor the build here. It should now contribute to this PR's status checks. Update: The results are in! |
|
Heya @ahejlsberg, I've started to run the extended test suite on this PR at c73affd. You can monitor the build here. It should now contribute to this PR's status checks. |
|
Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at c73affd. You can monitor the build here. It should now contribute to this PR's status checks. |
|
Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at c73affd. You can monitor the build here. It should now contribute to this PR's status checks. |
|
@ahejlsberg Here they are:Comparison Report - master..35266
System
Hosts
Scenarios
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
weswigham
reviewed
Nov 21, 2019
| @@ -14240,6 +14240,14 @@ namespace ts { | |||
| return getObjectFlags(source) & ObjectFlags.JsxAttributes && !isUnhyphenatedJsxName(sourceProp.escapedName); | |||
| } | |||
|
|
|||
| function getNormalizedType(type: Type, writing: boolean): Type { | |||
There was a problem hiding this comment.
We should be able to just move the loop into getNormalizedType.
weswigham
reviewed
Nov 21, 2019
| @@ -60,7 +60,7 @@ tests/cases/conformance/types/typeRelationships/recursiveTypes/recursiveTypeRefe | |||
|
|
|||
| const b20: Box2 = 42; // Error | |||
| ~~~ | |||
| !!! error TS2322: Type '42' is not assignable to type 'Box2'. | |||
| !!! error TS2322: Type '42' is not assignable to type 'Box<number | Box2>'. | |||
There was a problem hiding this comment.
😦 Is it possible we want to keep the pre-normalized form around for error reporting? Since it might have a nicer alias for us to use?
There was a problem hiding this comment.
I looked at doing that, but I'm not sure it really is all that valuable. We still display the alias in all other situations, it's only when we're elaborating into the type that we now display structure one level earlier that we would before. I think the few places it affects are just as well served with the change in this PR (which, BTW, is what we used to always do).
There was a problem hiding this comment.
I know, but we acknowledged that these errors were better - a nice side effect of the recursive alias change. it would be nice if we could keep them.
There was a problem hiding this comment.
Ok, changed the code to preserve the original type and use it in error reporting if it has an alias.
|
RWC tests have a few error baseline changes that I think are fine. Community tests suite changes are preexisting conditions. DT tests suites are clean. No changes in performance. Overall, I think this one is good to do. |
|
@typescript-bot test this |
|
Heya @ahejlsberg, I've started to run the perf test suite on this PR at 88d0315. You can monitor the build here. It should now contribute to this PR's status checks. Update: The results are in! |
|
Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 88d0315. You can monitor the build here. It should now contribute to this PR's status checks. |
|
Heya @ahejlsberg, I've started to run the extended test suite on this PR at 88d0315. You can monitor the build here. It should now contribute to this PR's status checks. |
|
Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at 88d0315. You can monitor the build here. It should now contribute to this PR's status checks. |
|
@ahejlsberg Here they are:Comparison Report - master..35266
System
Hosts
Scenarios
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
|
Looking at RWC, it looks like tuple aliases still aren't preserved in errors - is there an elaboration codepath the most recent change missed? (The elaboration in property relations, maybe?) |
weswigham
approved these changes
Nov 22, 2019
|
Actually, we're preserving type aliases in more situations than we did previously. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
isRelatedToto normalize type references before relating them. This in particular means that deferred type references are be turned into equivalent non-deferred type references before being compared, which reduces the amount of work we do and fixes an issue related to variance measurement of aliased deferred type references.Fixes #33872.