Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecatedCompat create/updateConstructorDeclaration functions #50260

Closed
wants to merge 1 commit into from

Conversation

frigus02
Copy link
Contributor

Fix an incorrect check for the body parameter of the deprecated overloads for create/updateConstructorDeclaration, which made them throw a type error at runtime.

Fixes #50259

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 10, 2022
@frigus02
Copy link
Contributor Author

Was fixed in #50343

@rbuckton
Copy link
Member

Ah, thanks! I'm sorry I didn't see this before submitting my PR.

@frigus02 frigus02 deleted the ts48-updatectordecl branch August 22, 2022 15:26
@frigus02
Copy link
Contributor Author

No worries. I'm just happy about the fix. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Deprecated decorator factory APIs throw "Invalid arguments" runtime error
3 participants