Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support supplying a watchFactory option that resolves the plugin and uses it for watching file or directory #51074

Closed
wants to merge 13 commits into from
Closed

Support supplying a watchFactory option that resolves the plugin and uses it for watching file or directory #51074

wants to merge 13 commits into from

Commits on Apr 13, 2023

  1. Add test using existing plugin 

    It shows that some of the watches couldnt be overriden before project is created
    @sheetalkamat
    sheetalkamat committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    ec8e9a0 View commit details
    Browse the repository at this point in the history

  2. Some refactoring so server require and system require match

    @sheetalkamat
    sheetalkamat committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    5af131f View commit details
    Browse the repository at this point in the history

  3. No Need to overwrite the require implementation

    @sheetalkamat
    sheetalkamat committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    d718275 View commit details
    Browse the repository at this point in the history

  4. Refactor

    @sheetalkamat
    sheetalkamat committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    6123b73 View commit details
    Browse the repository at this point in the history

  5. More refactoring

    @sheetalkamat
    sheetalkamat committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    9436c07 View commit details
    Browse the repository at this point in the history

  6. watchFactory option

    @sheetalkamat
    sheetalkamat committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    afc70c7 View commit details
    Browse the repository at this point in the history

  7. watchFactory implementation

    @sheetalkamat
    sheetalkamat committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    30335f7 View commit details
    Browse the repository at this point in the history

  8. Add onConfigurationChanged just like LS plugins

    @sheetalkamat
    sheetalkamat committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    f5bca5b View commit details
    Browse the repository at this point in the history

  9. Allow watchFactory as a object with name and configuration

    @sheetalkamat
    sheetalkamat committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    ac6b5e9 View commit details
    Browse the repository at this point in the history

  10. Add searchPaths option so we know where to look for watchFactory from… 

    … server which follows same locations as other Plugins
    @sheetalkamat
    sheetalkamat committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    0778047 View commit details
    Browse the repository at this point in the history

  11. Add plugin override for watchFactory

    @sheetalkamat
    sheetalkamat committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    b966bb9 View commit details
    Browse the repository at this point in the history

  12. Instead of passing complete typescript, pass in selected

    @sheetalkamat
    sheetalkamat committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    774b5d2 View commit details
    Browse the repository at this point in the history

  13. Add allowPlugins on commandline which is needed to resolve watchFactory

    @sheetalkamat
    sheetalkamat committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    9031ac6 View commit details
    Browse the repository at this point in the history