Convert Diagnostics to a module, direct import #55894

jakebailey · 2023-09-27T19:22:35Z

This is the same as #51455 but for the diagnostics module.

I was hoping this would tree shake out a bunch in tsc.js, but esbuild appears to not notice that a load of diagnostics (370 or so) are unused in tsc and can be removed. I need to report that upstream (could be evanw/esbuild#3256?), though maybe if I just @evanw he might be interested 😅

See discussion about the tree shaking; I've committed a workaround which has helped.

So far, the change is:

Overall package size

	Before	After	Diff	Diff (percent)
Packed	3.77 MiB	3.79 MiB	+21.74 KiB	+0.56%
Unpacked	20.37 MiB	20.53 MiB	+162.50 KiB	+0.78%

Files

	Before	After	Diff	Diff (percent)
`lib/tsc.js`	5.57 MiB	5.49 MiB	-86.12 KiB	-1.51%
`lib/typescript.js`	8.17 MiB	8.41 MiB	+248.62 KiB	+2.97%

[git-generate] set -x npm ci npx eslint . --fix

jakebailey · 2023-09-27T20:08:20Z

@typescript-bot perf test this

typescript-bot · 2023-09-27T20:08:23Z

Heya @jakebailey, I've started to run the regular perf test suite on this PR at abea810. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-27T20:29:02Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,013k (± 0.01%)}	_{294,848k (± 0.00%)}	_{-165k (- 0.06%)}	_294,833k	_294,863k	_{p=0.005 n=6}
_{Parse Time}	_{2.63s (± 0.37%)}	_{2.62s (± 0.20%)}	_{-0.01s (- 0.57%)}	_2.61s	_2.62s	_{p=0.009 n=6}
_{Bind Time}	_{0.83s (± 0.49%)}	_{0.83s (± 0.49%)}	_~	_0.83s	_0.84s	_{p=1.000 n=6}
_{Check Time}	_{8.08s (± 0.30%)}	_{8.04s (± 0.22%)}	_{-0.04s (- 0.49%)}	_8.01s	_8.06s	_{p=0.014 n=6}
_{Emit Time}	_{7.10s (± 1.31%)}	_{7.05s (± 0.23%)}	_~	_7.02s	_7.06s	_{p=0.511 n=6}
_{Total Time}	_{18.65s (± 0.51%)}	_{18.54s (± 0.11%)}	_{-0.11s (- 0.59%)}	_18.50s	_18.56s	_{p=0.007 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,554k (± 1.23%)}	_{191,558k (± 1.26%)}	_{-996k (- 0.52%)}	_190,538k	_196,495k	_{p=0.045 n=6}
_{Parse Time}	_{1.34s (± 0.61%)}	_{1.35s (± 1.15%)}	_~	_1.34s	_1.37s	_{p=0.796 n=6}
_{Bind Time}	_{0.73s (± 0.00%)}	_{0.73s (± 0.00%)}	_~	_0.73s	_0.73s	_{p=1.000 n=6}
_{Check Time}	_{9.18s (± 0.51%)}	_{9.15s (± 0.57%)}	_~	_9.10s	_9.23s	_{p=0.421 n=6}
_{Emit Time}	_{2.63s (± 0.74%)}	_{2.63s (± 0.46%)}	_~	_2.61s	_2.64s	_{p=1.000 n=6}
_{Total Time}	_{13.88s (± 0.38%)}	_{13.86s (± 0.48%)}	_~	_13.80s	_13.97s	_{p=0.470 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,235k (± 0.00%)}	_{347,089k (± 0.01%)}	_{-146k (- 0.04%)}	_347,062k	_347,144k	_{p=0.005 n=6}
_{Parse Time}	_{2.47s (± 0.42%)}	_{2.46s (± 0.42%)}	_~	_2.45s	_2.47s	_{p=0.142 n=6}
_{Bind Time}	_{0.94s (± 0.00%)}	_{0.94s (± 0.67%)}	_~	_0.93s	_0.95s	_{p=1.000 n=6}
_{Check Time}	_{6.87s (± 0.28%)}	_{6.82s (± 0.27%)}	_{-0.05s (- 0.70%)}	_6.80s	_6.85s	_{p=0.010 n=6}
_{Emit Time}	_{4.03s (± 0.43%)}	_{4.03s (± 0.20%)}	_~	_4.02s	_4.04s	_{p=0.741 n=6}
_{Total Time}	_{14.30s (± 0.21%)}	_{14.24s (± 0.20%)}	_{-0.06s (- 0.43%)}	_14.22s	_14.30s	_{p=0.015 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,517k (± 0.01%)}	_{302,453k (± 0.01%)}	_{-64k (- 0.02%)}	_302,413k	_302,485k	_{p=0.005 n=6}
_{Parse Time}	_{2.00s (± 1.00%)}	_{2.01s (± 0.58%)}	_~	_1.99s	_2.02s	_{p=0.411 n=6}
_{Bind Time}	_{1.00s (± 0.75%)}	_{1.00s (± 0.41%)}	_~	_0.99s	_1.00s	_{p=0.389 n=6}
_{Check Time}	_{6.25s (± 0.59%)}	_{6.27s (± 0.31%)}	_~	_6.24s	_6.29s	_{p=0.629 n=6}
_{Emit Time}	_{3.53s (± 0.23%)}	_{3.55s (± 1.01%)}	_~	_3.49s	_3.59s	_{p=0.088 n=6}
_{Total Time}	_{12.79s (± 0.23%)}	_{12.82s (± 0.33%)}	_~	_12.76s	_12.88s	_{p=0.147 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,471k (± 0.00%)}	_{470,311k (± 0.01%)}	_{-159k (- 0.03%)}	_470,282k	_470,356k	_{p=0.005 n=6}
_{Parse Time}	_{2.57s (± 0.55%)}	_{2.58s (± 0.65%)}	_~	_2.56s	_2.60s	_{p=0.328 n=6}
_{Bind Time}	_{1.00s (± 0.63%)}	_{0.99s (± 0.83%)}	_{-0.01s (- 1.33%)}	_0.98s	_1.00s	_{p=0.023 n=6}
_{Check Time}	_{16.63s (± 0.30%)}	_{16.64s (± 0.22%)}	_~	_16.59s	_16.70s	_{p=0.936 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.20s (± 0.24%)}	_{20.21s (± 0.24%)}	_~	_20.14s	_20.28s	_{p=1.000 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,553k (± 0.01%)}	_{512,186k (± 0.02%)}	_{-367k (- 0.07%)}	_512,045k	_512,368k	_{p=0.005 n=6}
_{Parse Time}	_{3.27s (± 0.26%)}	_{3.25s (± 0.23%)}	_{-0.01s (- 0.41%)}	_3.24s	_3.26s	_{p=0.020 n=6}
_{Bind Time}	_{1.55s (± 0.58%)}	_{1.54s (± 0.26%)}	_~	_1.54s	_1.55s	_{p=0.086 n=6}
_{Check Time}	_{2.83s (± 0.49%)}	_{2.85s (± 1.12%)}	_~	_2.81s	_2.90s	_{p=0.327 n=6}
_{Emit Time}	_{0.08s (± 5.21%)}	_{0.08s (± 4.99%)}	_~	_0.08s	_0.09s	_{p=0.218 n=6}
_{Total Time}	_{7.72s (± 0.23%)}	_{7.72s (± 0.45%)}	_~	_7.68s	_7.77s	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,364ms (± 1.01%)}	_{2,348ms (± 0.79%)}	_~	_2,330ms	_2,378ms	_{p=0.199 n=6}
_{Req 2 - geterr}	_{5,337ms (± 1.67%)}	_{5,465ms (± 0.28%)}	_{+129ms (+ 2.41%)}	_5,450ms	_5,487ms	_{p=0.013 n=6}
_{Req 3 - references}	_{327ms (± 0.54%)}	_{328ms (± 1.10%)}	_~	_324ms	_334ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{277ms (± 1.15%)}	_{273ms (± 0.30%)}	_{-4ms (- 1.38%)}	_273ms	_275ms	_{p=0.026 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{81ms (± 9.16%)}	_{90ms (± 0.00%)}	_{🔻+9ms (+11.57%)}	_90ms	_90ms	_{p=0.027 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,457ms (± 0.92%)}	_{2,491ms (± 1.20%)}	_~	_2,448ms	_2,519ms	_{p=0.064 n=6}
_{Req 2 - geterr}	_{4,133ms (± 2.30%)}	_{4,066ms (± 0.22%)}	_~	_4,050ms	_4,076ms	_{p=0.936 n=6}
_{Req 3 - references}	_{337ms (± 1.52%)}	_{392ms (± 6.08%)}	_{🔻+55ms (+16.29%)}	_344ms	_405ms	_{p=0.006 n=6}
_{Req 4 - navto}	_{282ms (± 0.65%)}	_{285ms (± 0.79%)}	_{+3ms (+ 1.12%)}	_283ms	_288ms	_{p=0.042 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{80ms (± 7.12%)}	_{71ms (± 1.14%)}	_{🟩-8ms (-10.46%)}	_71ms	_73ms	_{p=0.003 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,589ms (± 0.69%)}	_{2,585ms (± 0.48%)}	_~	_2,569ms	_2,600ms	_{p=0.378 n=6}
_{Req 2 - geterr}	_{1,693ms (± 2.76%)}	_{1,665ms (± 1.13%)}	_~	_1,646ms	_1,694ms	_{p=0.336 n=6}
_{Req 3 - references}	_{114ms (± 8.99%)}	_{113ms (± 9.72%)}	_~	_105ms	_127ms	_{p=0.742 n=6}
_{Req 4 - navto}	_{359ms (± 0.23%)}	_{358ms (± 0.18%)}	_~	_357ms	_359ms	_{p=0.177 n=6}
_{Req 5 - completionInfo count}	_{2,071 (± 0.00%)}	_{2,071 (± 0.00%)}	_~	_2,071	_2,071	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{306ms (± 2.65%)}	_{302ms (± 1.73%)}	_~	_296ms	_307ms	_{p=0.688 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{151.64ms (± 0.19%)}	_{152.00ms (± 0.16%)}	_{+0.36ms (+ 0.24%)}	_150.99ms	_154.01ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.75ms (± 0.16%)}	_{245.47ms (± 0.18%)}	_{🔻+17.72ms (+ 7.78%)}	_243.80ms	_250.00ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.63ms (± 0.18%)}	_{248.15ms (± 0.17%)}	_{🔻+19.52ms (+ 8.54%)}	_246.30ms	_255.46ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.86ms (± 0.17%)}	_{248.07ms (± 0.15%)}	_{🔻+19.22ms (+ 8.40%)}	_246.77ms	_253.38ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

evanw · 2023-09-29T18:05:52Z

I took a look and I know why this happens. Here is one of the diagnostics as an example:

export const Show_diagnostic_information: DiagnosticMessage =
  /* @__PURE__ */ diag(
    6149,
    DiagnosticCategory.Message,
    "Show_diagnostic_information_6149",
    "Show diagnostic information.");

The problem is that while the call to diag is marked as pure, that only neutralizes the side effects from the call itself. It does not affect any side effects from any of the arguments, which still take place. In particular, esbuild does not know whether the dynamic property access DiagnosticCategory.Message has side effects or not at the stage in the pipeline where esbuild is making these side effect decisions. This is because DiagnosticCategory is defined in a separate file and esbuild processes files in parallel.

One hack to fix this could be to move (or copy) the definition of DiagnosticCategory into that file. Another hack to fix this could be to wrap each diagnostic in an IIFE so that the arguments are included in the scope of /* @__PURE__ */. Obviously it would be best for esbuild to be able to determine that this is side-effect free itself without any code changes, but that is not necessarily straightforward on esbuild's end.

jakebailey · 2023-09-29T18:11:43Z

DiagnosticCategory is an enum, though; is it possible that the information of "this is an enum we're going to inline" could be used to determine that the operation is side effect free? IIRC enum info is collected at parse time, so I think it's known at that point...

jakebailey · 2023-09-29T18:17:21Z

Redeclaring it locally (or not using it at all) does work, though; I'll commit that workaround for now. Thanks for the suggestion!

evanw · 2023-09-29T18:17:48Z

The problem is a combination of:

Side effect decisions are currently made independently per file using just the syntactic information available to the parser for that file
The enum definition for DiagnosticCategory is in another file so the parser of diagnosticInformationMap.generated.ts doesn't have any information about DiagnosticCategory as it determines side effects for diagnosticInformationMap.generated.ts

This is an esbuild problem of course and not a problem inherent to all bundlers. You could imagine another implementation of esbuild that defers all optimization decisions until link time to handle things like this. That's not how esbuild currently works, however.

jakebailey · 2023-09-29T18:23:29Z

Ah, gotcha. Thanks for the explainer.

jakebailey · 2023-09-29T18:41:21Z

@typescript-bot perf test this
@typescript-bot perf test this bun

typescript-bot · 2023-09-29T18:41:24Z

Heya @jakebailey, I've started to run the bun perf test suite on this PR at c71fe64. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-29T18:41:24Z

Heya @jakebailey, I've started to run the regular perf test suite on this PR at c71fe64. You can monitor the build here.

Update: The results are in!

evanw · 2023-09-29T18:45:49Z

I have a bit of a weird bug report for you: #55915. I found it while trying to help you out here. I tried making an incompatible definition of DiagnosticCategory locally to sanity-check that the TypeScript compiler would flag it as an error but I was surprised to find that it didn't. It seems to be based on whether the two incompatible enum definitions are named the same thing or not in their respective files. Seems like a bug to me? So I figured I should report it. Hopefully it's a useful error report. Feel free to close if it's not though.

jakebailey · 2023-09-29T18:49:38Z

Thanks for that; I'm sure it's a bug! TS only "recently" started complaining about relating enums with compatible values, so I'm sure there are just more edge cases there.

jakebailey · 2023-09-29T18:54:13Z

The reason the package gets larger is thanks to this, which is needed in the public API (unfortunately people use this object even though it's internal so I'm afraid to remove it):

I had a WIP esbuild change which would have helped improve this; I need to resurrect that change and see if it's still workable. Basically, I had a version of __export which allowed you to specify ahead of time which values are const, though I don't quite know how I even had that working given __export is called before the module props are defined...

typescript-bot · 2023-09-29T19:01:06Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,055k (± 0.01%)}	_{294,706k (± 0.00%)}	_{-350k (- 0.12%)}	_294,695k	_294,711k	_{p=0.005 n=6}
_{Parse Time}	_{2.63s (± 0.44%)}	_{2.61s (± 0.29%)}	_{-0.02s (- 0.63%)}	_2.60s	_2.62s	_{p=0.032 n=6}
_{Bind Time}	_{0.84s (± 0.90%)}	_{0.83s (± 1.00%)}	_~	_0.83s	_0.85s	_{p=0.432 n=6}
_{Check Time}	_{8.08s (± 0.61%)}	_{8.03s (± 0.28%)}	_~	_7.99s	_8.05s	_{p=0.075 n=6}
_{Emit Time}	_{7.07s (± 0.53%)}	_{7.04s (± 0.33%)}	_~	_7.00s	_7.07s	_{p=0.157 n=6}
_{Total Time}	_{18.61s (± 0.45%)}	_{18.52s (± 0.13%)}	_{-0.09s (- 0.47%)}	_18.49s	_18.55s	_{p=0.013 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,630k (± 1.59%)}	_{191,343k (± 1.27%)}	_{-1,287k (- 0.67%)}	_190,337k	_196,301k	_{p=0.031 n=6}
_{Parse Time}	_{1.35s (± 1.36%)}	_{1.35s (± 2.03%)}	_~	_1.31s	_1.38s	_{p=1.000 n=6}
_{Bind Time}	_{0.73s (± 0.00%)}	_{0.73s (± 0.00%)}	_~	_0.73s	_0.73s	_{p=1.000 n=6}
_{Check Time}	_{9.22s (± 0.90%)}	_{9.11s (± 0.36%)}	_{-0.10s (- 1.12%)}	_9.06s	_9.16s	_{p=0.020 n=6}
_{Emit Time}	_{2.64s (± 0.79%)}	_{2.63s (± 0.32%)}	_~	_2.61s	_2.63s	_{p=0.219 n=6}
_{Total Time}	_{13.94s (± 0.67%)}	_{13.81s (± 0.35%)}	_{-0.13s (- 0.90%)}	_13.74s	_13.87s	_{p=0.045 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,307k (± 0.00%)}	_{346,919k (± 0.01%)}	_{-388k (- 0.11%)}	_346,896k	_346,949k	_{p=0.005 n=6}
_{Parse Time}	_{2.46s (± 0.21%)}	_{2.46s (± 0.43%)}	_~	_2.44s	_2.47s	_{p=0.794 n=6}
_{Bind Time}	_{0.94s (± 0.43%)}	_{0.92s (± 0.60%)}	_{-0.02s (- 2.49%)}	_0.91s	_0.92s	_{p=0.003 n=6}
_{Check Time}	_{6.91s (± 0.35%)}	_{6.84s (± 0.41%)}	_{-0.07s (- 0.94%)}	_6.79s	_6.87s	_{p=0.006 n=6}
_{Emit Time}	_{4.03s (± 0.55%)}	_{4.04s (± 0.40%)}	_~	_4.02s	_4.06s	_{p=0.680 n=6}
_{Total Time}	_{14.33s (± 0.31%)}	_{14.25s (± 0.22%)}	_{-0.08s (- 0.58%)}	_14.20s	_14.28s	_{p=0.013 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,590k (± 0.01%)}	_{302,297k (± 0.01%)}	_{-293k (- 0.10%)}	_302,275k	_302,329k	_{p=0.005 n=6}
_{Parse Time}	_{2.00s (± 0.45%)}	_{1.99s (± 0.75%)}	_~	_1.97s	_2.01s	_{p=0.445 n=6}
_{Bind Time}	_{1.00s (± 0.75%)}	_{1.00s (± 0.75%)}	_~	_0.99s	_1.01s	_{p=1.000 n=6}
_{Check Time}	_{6.25s (± 0.28%)}	_{6.25s (± 0.33%)}	_~	_6.23s	_6.28s	_{p=0.684 n=6}
_{Emit Time}	_{3.56s (± 0.66%)}	_{3.59s (± 0.48%)}	_{+0.04s (+ 0.98%)}	_3.57s	_3.62s	_{p=0.009 n=6}
_{Total Time}	_{12.80s (± 0.20%)}	_{12.84s (± 0.13%)}	_{+0.03s (+ 0.26%)}	_12.82s	_12.86s	_{p=0.043 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,471k (± 0.00%)}	_{470,147k (± 0.01%)}	_{-323k (- 0.07%)}	_470,109k	_470,190k	_{p=0.005 n=6}
_{Parse Time}	_{2.57s (± 0.29%)}	_{2.57s (± 0.43%)}	_~	_2.56s	_2.58s	_{p=0.865 n=6}
_{Bind Time}	_{1.00s (± 0.98%)}	_{0.99s (± 0.55%)}	_~	_0.99s	_1.00s	_{p=0.662 n=6}
_{Check Time}	_{16.68s (± 0.39%)}	_{16.57s (± 0.53%)}	_{-0.11s (- 0.65%)}	_16.47s	_16.70s	_{p=0.045 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.25s (± 0.31%)}	_{20.14s (± 0.45%)}	_{-0.11s (- 0.53%)}	_20.03s	_20.27s	_{p=0.045 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,654k (± 0.02%)}	_{511,698k (± 0.01%)}	_{-956k (- 0.19%)}	_511,616k	_511,794k	_{p=0.005 n=6}
_{Parse Time}	_{3.27s (± 0.57%)}	_{3.25s (± 0.37%)}	_~	_3.23s	_3.26s	_{p=0.074 n=6}
_{Bind Time}	_{1.55s (± 0.33%)}	_{1.54s (± 0.33%)}	_{-0.01s (- 0.64%)}	_1.54s	_1.55s	_{p=0.018 n=6}
_{Check Time}	_{2.85s (± 0.41%)}	_{2.86s (± 1.30%)}	_~	_2.79s	_2.89s	_{p=0.325 n=6}
_{Emit Time}	_{0.08s (± 4.99%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=0.405 n=6}
_{Total Time}	_{7.74s (± 0.31%)}	_{7.74s (± 0.63%)}	_~	_7.65s	_7.78s	_{p=0.748 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,347ms (± 0.94%)}	_{2,356ms (± 0.93%)}	_~	_2,328ms	_2,379ms	_{p=0.575 n=6}
_{Req 2 - geterr}	_{5,434ms (± 1.34%)}	_{5,470ms (± 0.24%)}	_~	_5,449ms	_5,483ms	_{p=0.378 n=6}
_{Req 3 - references}	_{326ms (± 0.19%)}	_{329ms (± 1.09%)}	_~	_325ms	_333ms	_{p=0.284 n=6}
_{Req 4 - navto}	_{275ms (± 0.44%)}	_{274ms (± 0.30%)}	_~	_274ms	_276ms	_{p=0.599 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{87ms (± 6.93%)}	_{89ms (± 2.29%)}	_~	_85ms	_90ms	_{p=0.599 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,473ms (± 1.95%)}	_{2,506ms (± 0.64%)}	_~	_2,476ms	_2,521ms	_{p=0.229 n=6}
_{Req 2 - geterr}	_{4,143ms (± 1.97%)}	_{4,072ms (± 0.26%)}	_~	_4,058ms	_4,090ms	_{p=0.230 n=6}
_{Req 3 - references}	_{335ms (± 0.44%)}	_{384ms (± 8.00%)}	_{🔻+49ms (+14.62%)}	_344ms	_406ms	_{p=0.005 n=6}
_{Req 4 - navto}	_{283ms (± 0.66%)}	_{287ms (± 1.30%)}	_{+5ms (+ 1.59%)}	_283ms	_293ms	_{p=0.028 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{75ms (± 1.08%)}	_{72ms (± 1.85%)}	_{🟩-4ms (- 4.65%)}	_71ms	_74ms	_{p=0.005 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,592ms (± 0.63%)}	_{2,580ms (± 0.53%)}	_~	_2,559ms	_2,598ms	_{p=0.149 n=6}
_{Req 2 - geterr}	_{1,700ms (± 2.02%)}	_{1,677ms (± 1.44%)}	_~	_1,654ms	_1,721ms	_{p=0.173 n=6}
_{Req 3 - references}	_{116ms (± 9.54%)}	_{109ms (± 7.31%)}	_~	_104ms	_125ms	_{p=0.210 n=6}
_{Req 4 - navto}	_{359ms (± 0.14%)}	_{358ms (± 0.23%)}	_~	_358ms	_360ms	_{p=0.235 n=6}
_{Req 5 - completionInfo count}	_{2,071 (± 0.00%)}	_{2,071 (± 0.00%)}	_~	_2,071	_2,071	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{305ms (± 1.71%)}	_{304ms (± 2.43%)}	_~	_295ms	_315ms	_{p=0.630 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{151.84ms (± 0.16%)}	_{150.65ms (± 0.17%)}	_{-1.18ms (- 0.78%)}	_149.75ms	_154.87ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.14ms (± 0.16%)}	_{244.74ms (± 0.18%)}	_{🔻+17.59ms (+ 7.74%)}	_243.34ms	_252.09ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.65ms (± 0.15%)}	_{248.13ms (± 0.15%)}	_{🔻+19.48ms (+ 8.52%)}	_246.61ms	_252.15ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.58ms (± 0.17%)}	_{247.99ms (± 0.18%)}	_{🔻+19.42ms (+ 8.49%)}	_246.43ms	_255.01ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-09-29T19:23:24Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - bun (v1.0.2, x64)}
_{Memory used}	_{317,028k (± 0.16%)}	_{317,581k (± 0.18%)}	_~	_315,541k	_318,684k	_{p=0.089 n=12}
_{Parse Time}	_{2.27s (± 0.31%)}	_{2.29s (± 0.41%)}	_{+0.02s (+ 0.70%)}	_2.26s	_2.31s	_{p=0.007 n=12}
_{Bind Time}	_{0.90s (± 2.11%)}	_{0.90s (± 1.99%)}	_~	_0.85s	_0.94s	_{p=0.930 n=12}
_{Check Time}	_{8.05s (± 0.24%)}	_{8.12s (± 0.53%)}	_{+0.07s (+ 0.84%)}	_8.03s	_8.21s	_{p=0.017 n=12}
_{Emit Time}	_{6.43s (± 0.37%)}	_{6.43s (± 0.37%)}	_~	_6.39s	_6.50s	_{p=0.908 n=12}
_{Total Time}	_{17.65s (± 0.23%)}	_{17.74s (± 0.37%)}	_{+0.09s (+ 0.49%)}	_17.54s	_17.88s	_{p=0.022 n=12}
_{Compiler-Unions - bun (v1.0.2, x64)}
_{Memory used}	_{248,995k (± 0.47%)}	_{248,450k (± 0.23%)}	_~	_246,883k	_250,379k	_{p=0.341 n=12}
_{Parse Time}	_{1.11s (± 0.81%)}	_{1.11s (± 0.74%)}	_~	_1.10s	_1.15s	_{p=0.686 n=12}
_{Bind Time}	_{0.84s (± 1.35%)}	_{0.83s (± 0.90%)}	_~	_0.80s	_0.85s	_{p=0.151 n=12}
_{Check Time}	_{8.79s (± 0.51%)}	_{8.82s (± 0.31%)}	_~	_8.76s	_8.90s	_{p=0.116 n=12}
_{Emit Time}	_{2.82s (± 0.72%)}	_{2.83s (± 0.49%)}	_~	_2.79s	_2.85s	_{p=0.414 n=12}
_{Total Time}	_{13.57s (± 0.33%)}	_{13.59s (± 0.24%)}	_~	_13.50s	_13.65s	_{p=0.270 n=12}
_{Monaco - bun (v1.0.2, x64)}
_{Memory used}	_{376,939k (± 0.37%)}	_{375,440k (± 0.37%)}	_{-1,498k (- 0.40%)}	_371,160k	_377,957k	_{p=0.040 n=12}
_{Parse Time}	_{1.96s (± 0.70%)}	_{1.97s (± 0.78%)}	_~	_1.94s	_2.00s	_{p=0.768 n=12}
_{Bind Time}	_{0.98s (± 1.99%)}	_{0.96s (± 1.77%)}	_~	_0.90s	_1.00s	_{p=0.067 n=12}
_{Check Time}	_{7.47s (± 0.27%)}	_{7.50s (± 0.38%)}	_~	_7.42s	_7.59s	_{p=0.109 n=12}
_{Emit Time}	_{3.78s (± 0.42%)}	_{3.79s (± 0.55%)}	_~	_3.75s	_3.85s	_{p=0.748 n=12}
_{Total Time}	_{14.19s (± 0.14%)}	_{14.21s (± 0.29%)}	_~	_14.09s	_14.35s	_{p=0.642 n=12}
_{TFS - bun (v1.0.2, x64)}
_{Memory used}	_{317,525k (± 0.18%)}	_{317,166k (± 0.13%)}	_~	_316,118k	_318,158k	_{p=0.237 n=12}
_{Parse Time}	_{1.74s (± 0.56%)}	_{1.73s (± 0.89%)}	_~	_1.72s	_1.80s	_{p=0.128 n=12}
_{Bind Time}	_{1.01s (± 1.94%)}	_{0.99s (± 1.53%)}	_~	_0.92s	_1.01s	_{p=0.240 n=12}
_{Check Time}	_{6.71s (± 0.26%)}	_{6.73s (± 0.32%)}	_~	_6.67s	_6.78s	_{p=0.231 n=12}
_{Emit Time}	_{3.48s (± 0.34%)}	_{3.46s (± 0.42%)}	_~	_3.43s	_3.51s	_{p=0.093 n=12}
_{Total Time}	_{12.94s (± 0.20%)}	_{12.92s (± 0.21%)}	_~	_12.82s	_12.98s	_{p=0.245 n=12}
_{material-ui - bun (v1.0.2, x64)}
_{Memory used}	_{497,630k (± 1.48%)}	_{498,936k (± 1.87%)}	_~	_471,703k	_514,794k	_{p=0.751 n=12}
_{Parse Time}	_{2.22s (± 0.39%)}	_{2.22s (± 0.36%)}	_~	_2.20s	_2.25s	_{p=0.611 n=12}
_{Bind Time}	_{0.71s (± 2.72%)}	_{0.74s (± 3.96%)}	_~	_0.69s	_0.81s	_{p=0.257 n=12}
_{Check Time}	_{15.87s (± 0.56%)}	_{15.79s (± 0.70%)}	_~	_15.50s	_16.15s	_{p=0.126 n=12}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=12}
_{Total Time}	_{18.81s (± 0.44%)}	_{18.75s (± 0.49%)}	_~	_18.52s	_19.08s	_{p=0.247 n=12}
_{xstate - bun (v1.0.2, x64)}
_{Memory used}	_{448,634k (± 4.26%)}	_{414,086k (± 6.11%)}	_{🟩-34,548k (- 7.70%)}	_379,917k	_461,310k	_{p=0.001 n=12}
_{Parse Time}	_{3.24s (± 0.26%)}	_{3.23s (± 0.49%)}	_~	_3.20s	_3.27s	_{p=0.485 n=12}
_{Bind Time}	_{1.26s (± 0.93%)}	_{1.26s (± 1.19%)}	_~	_1.24s	_1.33s	_{p=0.884 n=12}
_{Check Time}	_{3.60s (± 0.32%)}	_{3.61s (± 0.29%)}	_{+0.02s (+ 0.46%)}	_3.60s	_3.66s	_{p=0.025 n=12}
_{Emit Time}	_{0.21s (± 1.37%)}	_{0.21s (± 1.18%)}	_~	_0.20s	_0.21s	_{p=0.652 n=12}
_{Total Time}	_{8.31s (± 0.19%)}	_{8.32s (± 0.31%)}	_~	_8.27s	_8.42s	_{p=0.400 n=12}

System info unknown

Hosts

bun (v1.0.2, x64)

Scenarios

Angular - bun (v1.0.2, x64)
Compiler-Unions - bun (v1.0.2, x64)
Monaco - bun (v1.0.2, x64)
TFS - bun (v1.0.2, x64)
material-ui - bun (v1.0.2, x64)
xstate - bun (v1.0.2, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₁₂
_Baseline	_baseline	₁₂

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - bun (v1.0.2, x64)}
_{Execution time}	_{427.26ms (± 0.06%)}	_{425.97ms (± 0.09%)}	_{-1.30ms (- 0.30%)}	_425.07ms	_434.53ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - bun (v1.0.2, x64)}
_{Execution time}	_{661.57ms (± 0.13%)}	_{687.59ms (± 0.14%)}	_{+26.02ms (+ 3.93%)}	_685.77ms	_702.00ms	_{p=0.000 n=600}
_{typescript-startup - bun (v1.0.2, x64)}
_{Execution time}	_{662.00ms (± 0.10%)}	_{688.38ms (± 0.17%)}	_{+26.38ms (+ 3.98%)}	_686.62ms	_707.06ms	_{p=0.000 n=600}

System info unknown

Hosts

bun (v1.0.2, x64)

Scenarios

tsc-startup - bun (v1.0.2, x64)
tsserverlibrary-startup - bun (v1.0.2, x64)
typescript-startup - bun (v1.0.2, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey · 2023-09-29T19:23:49Z

Perf positive, that's nice. Bun seems to be slightly slower but unsure if that's real as it's so tiny.

jakebailey · 2024-06-28T23:19:43Z

Going to close this; we're moving more in the direction of being ESM, so there's no point in trying to make the diagnostics tree shakable in this way since we'd want to share the code.

jakebailey added 3 commits September 27, 2023 12:11

Make Diagnostics a module

905dd47

Pull lint rule over from debug-module branch

883336f

[generated] eslint --fix

abea810

[git-generate] set -x npm ci npx eslint . --fix

typescript-bot assigned jakebailey Sep 27, 2023

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Sep 27, 2023

Avoid using DiagnosticCategory directly to improve tree shaking

9f0c273

Merge branch 'main' into diagnostics-module-3

c71fe64

evanw mentioned this pull request Sep 29, 2023

TypeScript silently omits enum assignment type error between two enums with the same name #55915

Closed

jakebailey added 2 commits March 19, 2024 11:11

Merge branch 'main' into diagnostics-module-3

c287522

bad merge

c7f1ae2

jakebailey closed this Jun 28, 2024

jakebailey deleted the diagnostics-module-3 branch June 28, 2024 23:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert Diagnostics to a module, direct import #55894

Convert Diagnostics to a module, direct import #55894

jakebailey commented Sep 27, 2023 •

edited

Loading

jakebailey commented Sep 27, 2023

typescript-bot commented Sep 27, 2023 •

edited

Loading

typescript-bot commented Sep 27, 2023

Compiler

tsserver

Startup

evanw commented Sep 29, 2023

jakebailey commented Sep 29, 2023 •

edited

Loading

jakebailey commented Sep 29, 2023 •

edited

Loading

evanw commented Sep 29, 2023

jakebailey commented Sep 29, 2023

jakebailey commented Sep 29, 2023

typescript-bot commented Sep 29, 2023 •

edited

Loading

typescript-bot commented Sep 29, 2023 •

edited

Loading

evanw commented Sep 29, 2023

jakebailey commented Sep 29, 2023

jakebailey commented Sep 29, 2023

typescript-bot commented Sep 29, 2023

Compiler

tsserver

Startup

typescript-bot commented Sep 29, 2023

Compiler

Startup

jakebailey commented Sep 29, 2023

jakebailey commented Jun 28, 2024

Convert Diagnostics to a module, direct import #55894

Convert Diagnostics to a module, direct import #55894

Conversation

jakebailey commented Sep 27, 2023 • edited Loading

Overall package size

Files

jakebailey commented Sep 27, 2023

typescript-bot commented Sep 27, 2023 • edited Loading

typescript-bot commented Sep 27, 2023

Compiler

tsserver

Startup

evanw commented Sep 29, 2023

jakebailey commented Sep 29, 2023 • edited Loading

jakebailey commented Sep 29, 2023 • edited Loading

evanw commented Sep 29, 2023

jakebailey commented Sep 29, 2023

jakebailey commented Sep 29, 2023

typescript-bot commented Sep 29, 2023 • edited Loading

typescript-bot commented Sep 29, 2023 • edited Loading

evanw commented Sep 29, 2023

jakebailey commented Sep 29, 2023

jakebailey commented Sep 29, 2023

typescript-bot commented Sep 29, 2023

Compiler

tsserver

Startup

typescript-bot commented Sep 29, 2023

Compiler

Startup

jakebailey commented Sep 29, 2023

jakebailey commented Jun 28, 2024

jakebailey commented Sep 27, 2023 •

edited

Loading

typescript-bot commented Sep 27, 2023 •

edited

Loading

jakebailey commented Sep 29, 2023 •

edited

Loading

jakebailey commented Sep 29, 2023 •

edited

Loading

typescript-bot commented Sep 29, 2023 •

edited

Loading

typescript-bot commented Sep 29, 2023 •

edited

Loading