Consistently return `errorType` when detecting circularities #56429

Andarist · 2023-11-16T08:35:14Z

a quick experiment based on discussion/observations we had here: https://github.com/microsoft/TypeScript/pull/56258/files#r1393385776

typescript-bot · 2023-11-16T08:35:20Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Andarist · 2023-11-16T08:42:49Z

tests/baselines/reference/witness.errors.txt

@@ -2,24 +2,17 @@ witness.ts(4,21): error TS2372: Parameter 'pInit' cannot reference itself.
 witness.ts(8,14): error TS2729: Property 'x' is used before its initialization.
 witness.ts(20,5): error TS2403: Subsequent variable declarations must have the same type.  Variable 'a' must be of type 'any', but here has type 'never'.
 witness.ts(28,12): error TS2695: Left side of comma operator is unused and has no side effects.
-witness.ts(29,5): error TS2403: Subsequent variable declarations must have the same type.  Variable 'co1' must be of type 'any', but here has type 'number'.


it seems that this is even a small improvement since the intention of the caller was not to raise those errors when the type is the errorType, see: https://github.dev/microsoft/TypeScript/blob/32b618c2d8f42948e7d6fa2e9b264079e30b5349/src/compiler/checker.ts#L42290-L42296

Swinging back here, it seems sorta odd just from the PoV that a self referencing thing will just not have any errors. It seems like this test is mainly to "witness" the type of these expressions in errors, but maybe it's fine. Odd that the .types file does not show a change?

Will have to do some forensics but I'm not sure why we even want to ignore these anyway...

jakebailey · 2023-11-16T16:57:40Z

Honestly I like this better

@typescript-bot test top200
@typescript-bot user test this
@typescript-bot run dt

@typescript-bot perf test this
@typescript-bot pack this

typescript-bot · 2023-11-16T16:57:44Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at df7435d. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-16T16:57:44Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at df7435d. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-16T16:57:44Z

Heya @jakebailey, I've started to run the regular perf test suite on this PR at df7435d. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-16T16:57:44Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at df7435d. You can monitor the build here.

typescript-bot · 2023-11-16T16:57:44Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at df7435d. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-16T16:59:25Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/158643/artifacts?artifactName=tgz&fileId=1E5FC2A3954F892F1155CE85799029CEE36C40AFE8FB71B39396BAA5D40F93DE02&fileName=/typescript-5.4.0-insiders.20231116.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

Andarist · 2023-11-16T17:12:49Z

Honestly I like this better

Than the targeted if in #56258 ? Or in general? ;p

typescript-bot · 2023-11-16T17:15:48Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/56429/merge:

There were infrastructure failures potentially unrelated to your change:

2 instances of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L23 in packages/browsers/test/src/tsconfig.json

typescript-bot · 2023-11-16T17:21:36Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,199k (± 0.01%)}	_{295,193k (± 0.01%)}	_~	_295,167k	_295,220k	_{p=0.810 n=6}
_{Parse Time}	_{2.64s (± 0.31%)}	_{2.64s (± 0.44%)}	_~	_2.63s	_2.66s	_{p=0.738 n=6}
_{Bind Time}	_{0.83s (± 0.91%)}	_{0.83s (± 0.66%)}	_~	_0.82s	_0.83s	_{p=0.476 n=6}
_{Check Time}	_{8.03s (± 0.15%)}	_{8.04s (± 0.32%)}	_~	_8.01s	_8.07s	_{p=0.935 n=6}
_{Emit Time}	_{7.08s (± 0.39%)}	_{7.07s (± 0.43%)}	_~	_7.03s	_7.11s	_{p=0.629 n=6}
_{Total Time}	_{18.59s (± 0.16%)}	_{18.58s (± 0.21%)}	_~	_18.52s	_18.63s	_{p=0.687 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{191,662k (± 1.24%)}	_{191,669k (± 1.23%)}	_~	_190,672k	_196,474k	_{p=0.575 n=6}
_{Parse Time}	_{1.36s (± 0.89%)}	_{1.36s (± 0.98%)}	_~	_1.35s	_1.38s	_{p=0.865 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.17s (± 0.25%)}	_{9.18s (± 0.24%)}	_~	_9.15s	_9.21s	_{p=0.744 n=6}
_{Emit Time}	_{2.64s (± 0.56%)}	_{2.65s (± 0.73%)}	_~	_2.62s	_2.67s	_{p=0.372 n=6}
_{Total Time}	_{13.89s (± 0.21%)}	_{13.91s (± 0.15%)}	_~	_13.88s	_13.94s	_{p=0.295 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,352k (± 0.00%)}	_{347,335k (± 0.01%)}	_~	_347,302k	_347,381k	_{p=0.128 n=6}
_{Parse Time}	_{2.45s (± 0.31%)}	_{2.45s (± 0.68%)}	_~	_2.42s	_2.47s	_{p=1.000 n=6}
_{Bind Time}	_{0.92s (± 0.56%)}	_{0.92s (± 0.56%)}	_~	_0.92s	_0.93s	_{p=1.000 n=6}
_{Check Time}	_{6.89s (± 0.28%)}	_{6.91s (± 0.50%)}	_~	_6.87s	_6.96s	_{p=0.418 n=6}
_{Emit Time}	_{4.05s (± 0.22%)}	_{4.05s (± 0.20%)}	_~	_4.04s	_4.06s	_{p=0.550 n=6}
_{Total Time}	_{14.32s (± 0.14%)}	_{14.33s (± 0.36%)}	_~	_14.28s	_14.41s	_{p=0.744 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,630k (± 0.01%)}	_{302,648k (± 0.01%)}	_~	_302,610k	_302,705k	_{p=0.520 n=6}
_{Parse Time}	_{1.98s (± 1.06%)}	_{2.00s (± 0.86%)}	_~	_1.98s	_2.02s	_{p=0.118 n=6}
_{Bind Time}	_{1.00s (± 1.03%)}	_{1.00s (± 1.36%)}	_~	_0.99s	_1.02s	_{p=0.933 n=6}
_{Check Time}	_{6.28s (± 0.24%)}	_{6.28s (± 0.27%)}	_~	_6.25s	_6.30s	_{p=0.681 n=6}
_{Emit Time}	_{3.58s (± 0.71%)}	_{3.57s (± 0.33%)}	_~	_3.56s	_3.59s	_{p=0.569 n=6}
_{Total Time}	_{12.85s (± 0.22%)}	_{12.85s (± 0.21%)}	_~	_12.82s	_12.89s	_{p=0.936 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,557k (± 0.01%)}	_{470,581k (± 0.01%)}	_~	_470,543k	_470,632k	_{p=0.230 n=6}
_{Parse Time}	_{2.57s (± 0.64%)}	_{2.58s (± 0.29%)}	_~	_2.57s	_2.59s	_{p=0.672 n=6}
_{Bind Time}	_{0.99s (± 1.49%)}	_{1.00s (± 0.82%)}	_~	_0.99s	_1.01s	_{p=0.284 n=6}
_{Check Time}	_{16.61s (± 0.42%)}	_{16.66s (± 0.38%)}	_~	_16.54s	_16.71s	_{p=0.261 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.18s (± 0.38%)}	_{20.24s (± 0.32%)}	_~	_20.11s	_20.29s	_{p=0.199 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,818k (± 0.01%)}	_{512,815k (± 0.01%)}	_~	_512,766k	_512,902k	_{p=1.000 n=6}
_{Parse Time}	_{3.27s (± 0.19%)}	_{3.28s (± 0.17%)}	_~	_3.27s	_3.28s	_{p=0.201 n=6}
_{Bind Time}	_{1.54s (± 0.53%)}	_{1.54s (± 0.49%)}	_~	_1.53s	_1.55s	_{p=0.306 n=6}
_{Check Time}	_{2.86s (± 0.65%)}	_{2.87s (± 0.42%)}	_~	_2.86s	_2.89s	_{p=0.416 n=6}
_{Emit Time}	_{0.09s (± 6.44%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=0.071 n=6}
_{Total Time}	_{7.76s (± 0.25%)}	_{7.76s (± 0.16%)}	_~	_7.75s	_7.78s	_{p=0.366 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,360ms (± 0.51%)}	_{2,377ms (± 0.59%)}	_~	_2,363ms	_2,399ms	_{p=0.078 n=6}
_{Req 2 - geterr}	_{5,393ms (± 1.73%)}	_{5,361ms (± 1.72%)}	_~	_5,307ms	_5,547ms	_{p=0.936 n=6}
_{Req 3 - references}	_{325ms (± 0.42%)}	_{327ms (± 0.79%)}	_~	_323ms	_331ms	_{p=0.358 n=6}
_{Req 4 - navto}	_{277ms (± 1.20%)}	_{279ms (± 0.27%)}	_~	_278ms	_280ms	_{p=0.406 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{84ms (± 7.21%)}	_{80ms (± 7.15%)}	_~	_75ms	_91ms	_{p=0.295 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,494ms (± 0.77%)}	_{2,493ms (± 0.62%)}	_~	_2,475ms	_2,517ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{4,085ms (± 1.86%)}	_{4,080ms (± 1.87%)}	_~	_4,012ms	_4,179ms	_{p=0.748 n=6}
_{Req 3 - references}	_{341ms (± 1.69%)}	_{340ms (± 1.76%)}	_~	_332ms	_345ms	_{p=0.627 n=6}
_{Req 4 - navto}	_{283ms (± 0.43%)}	_{283ms (± 0.69%)}	_~	_281ms	_286ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{86ms (± 6.98%)}	_{85ms (± 7.21%)}	_~	_77ms	_90ms	_{p=1.000 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,595ms (± 0.68%)}	_{2,604ms (± 0.36%)}	_~	_2,595ms	_2,619ms	_{p=0.419 n=6}
_{Req 2 - geterr}	_{1,729ms (± 1.83%)}	_{1,723ms (± 2.36%)}	_~	_1,677ms	_1,772ms	_{p=0.936 n=6}
_{Req 3 - references}	_{119ms (± 7.10%)}	_{105ms (± 5.81%)}	_{🟩-14ms (-12.04%)}	_101ms	_117ms	_{p=0.029 n=6}
_{Req 4 - navto}	_{367ms (± 0.58%)}	_{367ms (± 0.57%)}	_~	_364ms	_369ms	_{p=0.743 n=6}
_{Req 5 - completionInfo count}	_{2,073 (± 0.00%)}	_{2,073 (± 0.00%)}	_~	_2,073	_2,073	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{311ms (± 1.97%)}	_{305ms (± 1.99%)}	_~	_300ms	_316ms	_{p=0.077 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{152.79ms (± 0.18%)}	_{152.75ms (± 0.17%)}	_~	_151.57ms	_156.08ms	_{p=0.364 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.18ms (± 0.17%)}	_{227.86ms (± 0.14%)}	_{-0.32ms (- 0.14%)}	_226.69ms	_230.44ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.06ms (± 0.17%)}	_{228.86ms (± 0.17%)}	_{-0.21ms (- 0.09%)}	_227.21ms	_234.76ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.44ms (± 0.16%)}	_{229.30ms (± 0.17%)}	_{-0.14ms (- 0.06%)}	_227.41ms	_232.45ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-11-16T17:46:52Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

jakebailey · 2023-11-16T17:53:38Z

Honestly I like this better

Than the targeted if in #56258 ? Or in general? ;p

Both!

typescript-bot · 2023-11-16T18:59:22Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/56429/merge:

Everything looks good!

tests/baselines/reference/assignmentCompatWithObjectMembers.types

Consistently return errorType when detecting circularities

df7435d

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 16, 2023

Andarist marked this pull request as draft November 16, 2023 08:35

Andarist commented Nov 16, 2023

View reviewed changes

Andarist marked this pull request as ready for review November 16, 2023 08:43

jakebailey mentioned this pull request Nov 17, 2023

Error on export default of type: issue https://github.com/microsoft/TypeScript/issues/55087 #55097

Merged

sandersn requested review from jakebailey and iisaduan November 29, 2023 17:56

sandersn assigned jakebailey Nov 29, 2023

Andarist mentioned this pull request Dec 12, 2023

Improve binding element type inference using CheckMode (rebased) #56753

Merged

jakebailey requested changes Jan 5, 2024

View reviewed changes

tests/baselines/reference/assignmentCompatWithObjectMembers.types Show resolved Hide resolved

jakebailey mentioned this pull request May 21, 2024

Propagate the error any type in union and intersection construction #58610

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Consistently return `errorType` when detecting circularities #56429

Consistently return `errorType` when detecting circularities #56429

Andarist commented Nov 16, 2023

typescript-bot commented Nov 16, 2023

Andarist Nov 16, 2023 •

edited

Loading

jakebailey Mar 26, 2024

jakebailey Mar 26, 2024

jakebailey commented Nov 16, 2023

typescript-bot commented Nov 16, 2023 •

edited

Loading

typescript-bot commented Nov 16, 2023 •

edited

Loading

typescript-bot commented Nov 16, 2023 •

edited

Loading

typescript-bot commented Nov 16, 2023 •

edited

Loading

typescript-bot commented Nov 16, 2023 •

edited

Loading

typescript-bot commented Nov 16, 2023 •

edited

Loading

Andarist commented Nov 16, 2023

typescript-bot commented Nov 16, 2023

puppeteer

packages/browsers/test/src/tsconfig.json

typescript-bot commented Nov 16, 2023

Compiler

tsserver

Startup

typescript-bot commented Nov 16, 2023

jakebailey commented Nov 16, 2023

typescript-bot commented Nov 16, 2023

Consistently return errorType when detecting circularities #56429

Are you sure you want to change the base?

Consistently return errorType when detecting circularities #56429

Conversation

Andarist commented Nov 16, 2023

typescript-bot commented Nov 16, 2023

Andarist Nov 16, 2023 • edited Loading

Choose a reason for hiding this comment

jakebailey Mar 26, 2024

Choose a reason for hiding this comment

jakebailey Mar 26, 2024

Choose a reason for hiding this comment

jakebailey commented Nov 16, 2023

typescript-bot commented Nov 16, 2023 • edited Loading

typescript-bot commented Nov 16, 2023 • edited Loading

typescript-bot commented Nov 16, 2023 • edited Loading

typescript-bot commented Nov 16, 2023 • edited Loading

typescript-bot commented Nov 16, 2023 • edited Loading

typescript-bot commented Nov 16, 2023 • edited Loading

Andarist commented Nov 16, 2023

typescript-bot commented Nov 16, 2023

puppeteer

packages/browsers/test/src/tsconfig.json

typescript-bot commented Nov 16, 2023

Compiler

tsserver

Startup

typescript-bot commented Nov 16, 2023

jakebailey commented Nov 16, 2023

typescript-bot commented Nov 16, 2023

Consistently return `errorType` when detecting circularities #56429

Consistently return `errorType` when detecting circularities #56429

Andarist Nov 16, 2023 •

edited

Loading

typescript-bot commented Nov 16, 2023 •

edited

Loading

typescript-bot commented Nov 16, 2023 •

edited

Loading

typescript-bot commented Nov 16, 2023 •

edited

Loading

typescript-bot commented Nov 16, 2023 •

edited

Loading

typescript-bot commented Nov 16, 2023 •

edited

Loading

typescript-bot commented Nov 16, 2023 •

edited

Loading