Don't indirect through _namespaces in tsserver/typingsInstaller #57829

jakebailey · 2024-03-18T15:28:36Z

A follow-up to #55326 which directly pulls from the public API project rather than indirecting through _namespaces, which incurs an extra copy due to esbuild's helpers.

I expect the bundle size to get larger due to the name esbuild chooses for the module, but potentially faster to load as it's not recreating a public API object.

This also likely locks off using named imports for nested modules as asked about in #55326 (review), but I have not found a way to do those within our current import syntax.

jakebailey · 2024-03-18T15:28:48Z

@typescript-bot perf test this

typescript-bot · 2024-03-18T15:28:51Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results

typescript-bot · 2024-03-18T16:09:38Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,704k (± 0.01%)}	_{295,717k (± 0.00%)}	_~	_295,706k	_295,738k	_{p=0.423 n=6}
_{Parse Time}	_{2.66s (± 0.19%)}	_{2.66s (± 0.31%)}	_~	_2.64s	_2.66s	_{p=0.114 n=6}
_{Bind Time}	_{0.83s (± 0.49%)}	_{0.83s (± 0.49%)}	_~	_0.82s	_0.83s	_{p=1.000 n=6}
_{Check Time}	_{8.21s (± 0.44%)}	_{8.22s (± 0.33%)}	_~	_8.19s	_8.27s	_{p=0.624 n=6}
_{Emit Time}	_{7.15s (± 0.23%)}	_{7.16s (± 0.36%)}	_~	_7.11s	_7.18s	_{p=0.406 n=6}
_{Total Time}	_{18.85s (± 0.19%)}	_{18.86s (± 0.14%)}	_~	_18.82s	_18.89s	_{p=0.566 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,185k (± 0.90%)}	_{192,006k (± 0.10%)}	_~	_191,883k	_192,410k	_{p=0.298 n=6}
_{Parse Time}	_{1.37s (± 0.89%)}	_{1.35s (± 1.15%)}	_~	_1.33s	_1.36s	_{p=0.103 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.52s (± 0.60%)}	_{9.55s (± 0.55%)}	_~	_9.49s	_9.63s	_{p=0.334 n=6}
_{Emit Time}	_{2.65s (± 0.24%)}	_{2.65s (± 0.67%)}	_~	_2.63s	_2.67s	_{p=1.000 n=6}
_{Total Time}	_{14.26s (± 0.37%)}	_{14.28s (± 0.37%)}	_~	_14.22s	_14.36s	_{p=0.571 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,367k (± 0.01%)}	_{347,360k (± 0.00%)}	_~	_347,341k	_347,373k	_{p=0.873 n=6}
_{Parse Time}	_{2.49s (± 0.60%)}	_{2.48s (± 0.30%)}	_~	_2.47s	_2.49s	_{p=0.187 n=6}
_{Bind Time}	_{0.93s (± 0.56%)}	_{0.92s (± 0.88%)}	_~	_0.91s	_0.93s	_{p=0.523 n=6}
_{Check Time}	_{7.03s (± 0.38%)}	_{7.03s (± 0.51%)}	_~	_6.99s	_7.08s	_{p=0.746 n=6}
_{Emit Time}	_{4.07s (± 0.48%)}	_{4.06s (± 0.76%)}	_~	_4.02s	_4.10s	_{p=0.808 n=6}
_{Total Time}	_{14.51s (± 0.17%)}	_{14.49s (± 0.25%)}	_~	_14.44s	_14.54s	_{p=0.329 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,739k (± 0.01%)}	_{302,737k (± 0.00%)}	_~	_302,711k	_302,751k	_{p=0.520 n=6}
_{Parse Time}	_{2.01s (± 0.87%)}	_{2.01s (± 1.29%)}	_~	_1.98s	_2.05s	_{p=0.418 n=6}
_{Bind Time}	_{1.00s (± 0.75%)}	_{1.01s (± 1.25%)}	_~	_0.99s	_1.02s	_{p=0.115 n=6}
_{Check Time}	_{6.31s (± 0.44%)}	_{6.30s (± 0.49%)}	_~	_6.26s	_6.35s	_{p=0.683 n=6}
_{Emit Time}	_{3.61s (± 0.42%)}	_{3.61s (± 0.25%)}	_~	_3.60s	_3.62s	_{p=0.801 n=6}
_{Total Time}	_{12.94s (± 0.22%)}	_{12.93s (± 0.19%)}	_~	_12.90s	_12.96s	_{p=0.743 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{511,371k (± 0.00%)}	_{511,379k (± 0.01%)}	_~	_511,357k	_511,419k	_{p=0.575 n=6}
_{Parse Time}	_{2.65s (± 0.46%)}	_{2.66s (± 0.73%)}	_~	_2.63s	_2.69s	_{p=0.390 n=6}
_{Bind Time}	_{0.98s (± 1.63%)}	_{0.99s (± 0.52%)}	_~	_0.98s	_0.99s	_{p=0.923 n=6}
_{Check Time}	_{17.32s (± 0.45%)}	_{17.39s (± 0.37%)}	_~	_17.30s	_17.49s	_{p=0.092 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.95s (± 0.35%)}	_{21.04s (± 0.24%)}	_{+0.08s (+ 0.40%)}	_20.98s	_21.13s	_{p=0.045 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,798,670k (± 0.00%)}	_{1,798,709k (± 0.00%)}	_~	_1,798,681k	_1,798,753k	_{p=0.128 n=6}
_{Parse Time}	_{6.61s (± 0.30%)}	_{6.63s (± 0.61%)}	_~	_6.60s	_6.71s	_{p=0.418 n=6}
_{Bind Time}	_{2.39s (± 0.53%)}	_{2.39s (± 0.31%)}	_~	_2.38s	_2.40s	_{p=0.676 n=6}
_{Check Time}	_{59.41s (± 0.85%)}	_{59.21s (± 0.52%)}	_~	_58.72s	_59.56s	_{p=0.689 n=6}
_{Emit Time}	_{0.16s (± 3.16%)}	_{0.16s (± 3.16%)}	_~	_0.16s	_0.17s	_{p=1.000 n=6}
_{Total Time}	_{68.57s (± 0.76%)}	_{68.40s (± 0.41%)}	_~	_67.99s	_68.73s	_{p=0.689 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,397,262k (± 0.04%)}	_{2,397,092k (± 0.01%)}	_~	_2,396,598k	_2,397,473k	_{p=0.378 n=6}
_{Parse Time}	_{5.01s (± 1.14%)}	_{5.01s (± 0.45%)}	_~	_4.97s	_5.03s	_{p=0.936 n=6}
_{Bind Time}	_{1.91s (± 0.66%)}	_{1.91s (± 0.86%)}	_~	_1.89s	_1.93s	_{p=0.681 n=6}
_{Check Time}	_{33.52s (± 0.45%)}	_{33.43s (± 0.31%)}	_~	_33.26s	_33.57s	_{p=0.230 n=6}
_{Emit Time}	_{2.75s (± 1.58%)}	_{2.74s (± 1.42%)}	_~	_2.67s	_2.77s	_{p=0.575 n=6}
_{Total Time}	_{43.20s (± 0.42%)}	_{43.11s (± 0.35%)}	_~	_42.85s	_43.24s	_{p=0.575 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{415,480k (± 0.01%)}	_{415,477k (± 0.01%)}	_~	_415,418k	_415,527k	_{p=0.689 n=6}
_{Parse Time}	_{2.82s (± 0.82%)}	_{2.81s (± 0.73%)}	_~	_2.78s	_2.84s	_{p=0.567 n=6}
_{Bind Time}	_{1.07s (± 0.70%)}	_{1.08s (± 0.48%)}	_~	_1.07s	_1.08s	_{p=0.247 n=6}
_{Check Time}	_{15.34s (± 0.45%)}	_{15.33s (± 0.24%)}	_~	_15.29s	_15.39s	_{p=1.000 n=6}
_{Emit Time}	_{1.15s (± 0.65%)}	_{1.15s (± 0.90%)}	_~	_1.14s	_1.16s	_{p=0.664 n=6}
_{Total Time}	_{20.38s (± 0.39%)}	_{20.36s (± 0.23%)}	_~	_20.30s	_20.41s	_{p=1.000 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,882,549k (± 0.00%)}	_{2,882,556k (± 0.00%)}	_~	_2,882,516k	_2,882,622k	_{p=0.575 n=6}
_{Parse Time}	_{10.79s (± 0.18%)}	_{10.83s (± 0.21%)}	_{+0.04s (+ 0.36%)}	_10.80s	_10.86s	_{p=0.023 n=6}
_{Bind Time}	_{3.45s (± 0.38%)}	_{3.46s (± 0.35%)}	_~	_3.44s	_3.47s	_{p=0.615 n=6}
_{Check Time}	_{61.60s (± 0.53%)}	_{61.41s (± 0.24%)}	_~	_61.17s	_61.56s	_{p=0.199 n=6}
_{Emit Time}	_{16.95s (± 7.86%)}	_{16.38s (± 0.56%)}	_~	_16.26s	_16.49s	_{p=0.521 n=6}
_{Total Time}	_{92.80s (± 1.69%)}	_{92.08s (± 0.15%)}	_~	_91.94s	_92.27s	_{p=0.228 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{406,474k (± 0.02%)}	_{406,506k (± 0.01%)}	_~	_406,431k	_406,584k	_{p=0.261 n=6}
_{Parse Time}	_{3.20s (± 0.72%)}	_{3.24s (± 0.41%)}	_{+0.04s (+ 1.25%)}	_3.22s	_3.26s	_{p=0.010 n=6}
_{Bind Time}	_{1.38s (± 0.75%)}	_{1.38s (± 0.30%)}	_~	_1.38s	_1.39s	_{p=0.545 n=6}
_{Check Time}	_{14.25s (± 0.23%)}	_{14.24s (± 0.43%)}	_~	_14.16s	_14.31s	_{p=0.570 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.83s (± 0.21%)}	_{18.86s (± 0.35%)}	_~	_18.79s	_18.94s	_{p=0.687 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,270k (± 0.01%)}	_{513,303k (± 0.02%)}	_~	_513,213k	_513,470k	_{p=0.630 n=6}
_{Parse Time}	_{3.28s (± 0.30%)}	_{3.28s (± 0.23%)}	_~	_3.27s	_3.29s	_{p=0.652 n=6}
_{Bind Time}	_{1.55s (± 0.49%)}	_{1.54s (± 0.26%)}	_~	_1.54s	_1.55s	_{p=0.100 n=6}
_{Check Time}	_{2.85s (± 0.47%)}	_{2.86s (± 0.60%)}	_~	_2.84s	_2.89s	_{p=0.317 n=6}
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 0.00%)}	_~	_0.07s	_0.07s	_{p=1.000 n=6}
_{Total Time}	_{7.75s (± 0.13%)}	_{7.75s (± 0.20%)}	_~	_7.74s	_7.78s	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,346ms (± 0.60%)}	_{2,364ms (± 0.60%)}	_{+19ms (+ 0.79%)}	_2,336ms	_2,374ms	_{p=0.020 n=6}
_{Req 2 - geterr}	_{5,781ms (± 0.41%)}	_{5,632ms (± 1.62%)}	_{-149ms (- 2.57%)}	_5,570ms	_5,812ms	_{p=0.045 n=6}
_{Req 3 - references}	_{327ms (± 1.20%)}	_{322ms (± 1.18%)}	_~	_319ms	_328ms	_{p=0.063 n=6}
_{Req 4 - navto}	_{273ms (± 0.36%)}	_{277ms (± 0.00%)}	_{+4ms (+ 1.40%)}	_277ms	_277ms	_{p=0.002 n=6}
_{Req 5 - completionInfo count}	_{1,357 (± 0.00%)}	_{1,357 (± 0.00%)}	_~	_1,357	_1,357	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{92ms (± 7.10%)}	_{84ms (± 0.48%)}	_~	_84ms	_85ms	_{p=0.054 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,487ms (± 1.20%)}	_{2,488ms (± 0.86%)}	_~	_2,469ms	_2,522ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{4,265ms (± 0.21%)}	_{4,117ms (± 0.20%)}	_{🟩-147ms (- 3.45%)}	_4,108ms	_4,126ms	_{p=0.005 n=6}
_{Req 3 - references}	_{332ms (± 0.27%)}	_{333ms (± 0.58%)}	_~	_329ms	_334ms	_{p=0.117 n=6}
_{Req 4 - navto}	_{284ms (± 0.47%)}	_{286ms (± 0.14%)}	_{+2ms (+ 0.70%)}	_286ms	_287ms	_{p=0.010 n=6}
_{Req 5 - completionInfo count}	_{1,519 (± 0.00%)}	_{1,519 (± 0.00%)}	_~	_1,519	_1,519	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{78ms (± 0.81%)}	_{73ms (± 0.70%)}	_{🟩-5ms (- 5.98%)}	_73ms	_74ms	_{p=0.004 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,620ms (± 0.15%)}	_{2,624ms (± 0.42%)}	_~	_2,609ms	_2,641ms	_{p=0.423 n=6}
_{Req 2 - geterr}	_{1,711ms (± 2.61%)}	_{1,741ms (± 2.28%)}	_~	_1,692ms	_1,777ms	_{p=0.261 n=6}
_{Req 3 - references}	_{126ms (± 3.59%)}	_{119ms (± 9.38%)}	_~	_108ms	_130ms	_{p=0.683 n=6}
_{Req 4 - navto}	_{373ms (± 1.52%)}	_{372ms (± 1.04%)}	_~	_364ms	_375ms	_{p=0.744 n=6}
_{Req 5 - completionInfo count}	_{2,079 (± 0.00%)}	_{2,079 (± 0.00%)}	_~	_2,079	_2,079	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{305ms (± 1.41%)}	_{303ms (± 1.96%)}	_~	_294ms	_310ms	_{p=0.295 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{153.98ms (± 0.15%)}	_{153.87ms (± 0.17%)}	_{-0.11ms (- 0.07%)}	_152.63ms	_156.71ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.59ms (± 0.18%)}	_{226.40ms (± 0.15%)}	_{-2.19ms (- 0.96%)}	_225.13ms	_230.54ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{222.10ms (± 0.15%)}	_{222.00ms (± 0.17%)}	_{-0.09ms (- 0.04%)}	_220.66ms	_229.16ms	_{p=0.001 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{222.83ms (± 0.18%)}	_{223.02ms (± 0.16%)}	_{+0.19ms (+ 0.09%)}	_221.37ms	_228.48ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey · 2024-03-18T16:20:43Z

Like 1% on tsserver, not exactly amazing.

jakebailey · 2024-03-19T16:07:40Z

But, probably worth it to not have _namespaces anymore.

Don't indirect through _namespaces in tsserver/typingsInstaller

82a1f32

typescript-bot assigned jakebailey Mar 18, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 18, 2024

jakebailey marked this pull request as ready for review March 19, 2024 16:07

jakebailey requested review from weswigham and andrewbranch March 19, 2024 16:09

DanielRosenwasser approved these changes Mar 20, 2024

View reviewed changes

jakebailey merged commit dc113f8 into microsoft:main Mar 20, 2024
26 checks passed

jakebailey deleted the new-bundle-cleanup branch March 20, 2024 23:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't indirect through _namespaces in tsserver/typingsInstaller #57829

Don't indirect through _namespaces in tsserver/typingsInstaller #57829

jakebailey commented Mar 18, 2024 •

edited

Loading

jakebailey commented Mar 18, 2024

typescript-bot commented Mar 18, 2024 •

edited

Loading

typescript-bot commented Mar 18, 2024

tsc

tsserver

startup

jakebailey commented Mar 18, 2024

jakebailey commented Mar 19, 2024

Don't indirect through _namespaces in tsserver/typingsInstaller #57829

Don't indirect through _namespaces in tsserver/typingsInstaller #57829

Conversation

jakebailey commented Mar 18, 2024 • edited Loading

jakebailey commented Mar 18, 2024

typescript-bot commented Mar 18, 2024 • edited Loading

typescript-bot commented Mar 18, 2024

tsc

tsserver

startup

jakebailey commented Mar 18, 2024

jakebailey commented Mar 19, 2024

jakebailey commented Mar 18, 2024 •

edited

Loading

typescript-bot commented Mar 18, 2024 •

edited

Loading