-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(58584): formatJSDocLink shouldn't introduce a trailing space when non link text. #58585
Conversation
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
2170a23
to
c56639a
Compare
If anyone come over here, I'd appreciate some help to fix the formating of |
ecc5cf8
to
e7150ac
Compare
Looks like a line ending problem. Did you use the baseline-accept task or did you manually modify the baseline? |
I changed the file manually. |
Yeah, you shouldn't do that. Run the tests then run |
… non link text. fixes microsoft#58584
@jakebailey Thanks, it looks better now ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems correct to me. @sandersn may have a thought here.
I was briefly worried about the treatment of spaces with http:// but there are lots of tests of that already. |
fixes #58584