-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark file as skips typechecking if it contains ts-nocheck #58593
Conversation
f3189ed
to
989d088
Compare
989d088
to
ca1ff15
Compare
@typescript-bot test it |
Hey @sheetalkamat, the results of running the DT tests are ready. Everything looks the same! |
@sheetalkamat Here are the results of running the user tests comparing Everything looks good! |
@sheetalkamat Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
@sheetalkamat Here are the results of running the top 400 repos comparing Everything looks good! |
Does this need to wait for #58364 given the ts-nocheck files may be emitting js? |
Either that or, like the other PR, only enabled when only |
Thats tough I think and not work flowing information temporarily till we get the PR in so i will just wait for that PR to merge. |
#58364 is in, so is this safe to update and get in? |
Yeah, just remember the condition in |
@weswigham pls review again. I have merged with main and added those checks Also i used canIncludeBind* function instead of skipsTypeChecking to avoid having to do extra checks (or get sourceFile if not needed) |
@weswigham pls review so i can get this in for 5.5 |
* upstream/main: (37 commits) Added NoTruncation flag to completions (microsoft#58719) Clone node to remove location even when it has been modified if needed (microsoft#58706) Properly account for `this` argument in intersection apparent type caching (microsoft#58677) Fix: Include Values of Script Extensions for Unicode Property Value Expressions in Regular Expressions (microsoft#58615) In `reScanSlashToken` use `charCodeChecked` not `codePointChecked` (microsoft#58727) Shorten error spans for errors reported on constructor declarations (microsoft#58061) Mark file as skips typechecking if it contains ts-nocheck (microsoft#58593) Fixed an issue with broken `await using` declarations in `for of` loops (microsoft#56466) Do not expand type references in keyof and index access (microsoft#58715) Improve the performance of isolatedDeclarations quickfix (microsoft#58722) Unwrap `NoInfer` types when narrowing (microsoft#58292) Recover from type reuse errors by falling back to inferred type printing (microsoft#58720) Fixing self import (microsoft#58718) Enable JS emit for noCheck and noCheck for transpileModule (microsoft#58364) Revert PR 55371 (microsoft#58702) Update dependencies (microsoft#58639) Fix baselines after PR 58621 (microsoft#58705) Do not infer `yield*` type from contextual `TReturn` (microsoft#58621) `await using` normative changes (microsoft#58624) Handling statements from a known source file (microsoft#58679) ...
This is different take on #58592 to skip checking only if no-checkJs
Frankly i dont know what all will fail because we dont have enough coverage for js + incremental as such from this perspective.
cc: @weswigham
From investigating #56956
Needs #58364 to work correctly for js emit