Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix elided var handling in declaration emit visibility checks #58605

Merged
merged 2 commits into from
May 21, 2024
Merged

Fix elided var handling in declaration emit visibility checks #58605

merged 2 commits into from
May 21, 2024

Conversation

weswigham
Copy link
Member

Fixes #58557

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 21, 2024
@weswigham weswigham marked this pull request as ready for review May 21, 2024 20:23
@weswigham weswigham requested a review from jakebailey May 21, 2024 20:24
@weswigham weswigham merged commit 6f72e24 into microsoft:main May 21, 2024
28 checks passed
@weswigham weswigham deleted the declaration-emit-elided-var branch May 21, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheetalkamat sheetalkamat sheetalkamat approved these changes

@jakebailey jakebailey jakebailey approved these changes

Assignees

@weswigham weswigham

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hoisted vars in blocks at module scope generate in invalid d.ts files when referenced using typeof
4 participants
@weswigham @jakebailey @sheetalkamat @typescript-bot