Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Fix **Kubernetes@1** job to officially accept **command** rollout. #20562

Open
4 of 7 tasks
mislavmatijevic opened this issue Oct 17, 2024 · 0 comments
Open
4 of 7 tasks

Comments

@mislavmatijevic
Copy link

New issue checklist

Task name

Kubernetes

Task version

1

Issue Description

Description

When a command "rollout" is used with Kubernetes@1 job, the extension reports "Value is not accepted" which is completely false: job works as intended.
Image
(reports "not accepted", however it does work)

This was already reported on StackOverflow 4 years by someone else: https://stackoverflow.com/questions/64268770/azure-devops-pipeline-kubectl-task-command-rollout-unavailable

I think this misinformation really needs to get fixed. I almost ended up thinking your Kubernetes job does not accept rollout command and that I'd have to use "delete" on pods found via labels instead of a normal, graceful rollout restart.

Actual code which needs fixing

You can see here (azure-pipelines-tasks/Tasks/KubernetesV1/task.json)(https://github.com/microsoft/azure-pipelines-tasks/blob/master/Tasks/KubernetesV1/task.json#L141-L154) that rollout is not one of the "accepted" commands, despite it being very important and working nonetheless.

I gather it'd be enough to just add the command here in the JSON object.

Environment type (Please select at least one enviroment where you face this issue)

  • Self-Hosted
  • Microsoft Hosted
  • VMSS Pool
  • Container

Azure DevOps Server type

dev.azure.com (formerly visualstudio.com)

Azure DevOps Server Version (if applicable)

No response

Operation system

MacOS

Relevant log output

There are no logs, it's just an issue with a missing key.

Full task logs with system.debug enabled

 N/A 

Repro steps

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants