Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes@1 reports 'rollout' is not an accepted command when it is #600

Closed
mislavmatijevic opened this issue Oct 16, 2024 · 3 comments
Closed

Comments

@mislavmatijevic
Copy link

In short

Fix Kubernetes@1 job to accept command rollout.

More details

When a command "rollout" is used with Kubernetes@1 job, the extension reports "Value is not accepted" which is completely false: job works as intended.
Image
(reports "not accepted", however it does work)

This was already reported on StackOverflow 4 years by someone else: https://stackoverflow.com/questions/64268770/azure-devops-pipeline-kubectl-task-command-rollout-unavailable

I think this misinformation really needs to get fixed. I almost ended up thinking your Kubernetes job does not accept rollout command and that I'd have to use "delete" on pods found via labels instead of a normal, graceful rollout restart.

@winstliu
Copy link
Member

Thanks for reporting @mislavmatijevic - sorry for the confusion. Could you please re-file this over at https://github.com/microsoft/azure-pipelines-tasks? That repo contains the completion definitions for individual tasks (see https://github.com/microsoft/azure-pipelines-tasks/blob/master/Tasks/KubernetesV1/task.json#L141-L154 which is missing the rollout command).

@winstliu winstliu closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2024
@mislavmatijevic
Copy link
Author

Hello @50Wliu, thanks for such a quick response.

I noticed the enumeration of the command values for the Kubernetes@1 job without the rollout command in question on this repo and therefore opened an issue here. I'll open a new one on that other link. Thanks again!

@mislavmatijevic
Copy link
Author

For anyone coming across this issue in the future, I reopened it here: microsoft/azure-pipelines-tasks#20562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants