[CopyFilesOverSSH] Migrated to ssh2-sftp-client library #13312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdobrodeev
force-pushed
the
users/sdobrodeev/feature13048_CopyFilesOverSSH_sftp_migration
branch
from
53385bb to
b9a6cfd
Compare
This was
linked to
issues
Jul 17, 2020
| defer.resolve(true); | ||
| } | ||
| }) | ||
| if (await this.sftpClient.stat(path)) { |
There was a problem hiding this comment.
What a point to use stat method here? I assume we can use the exists method from ssh2-sftp-client. So code be more clear:
const isPathExist: boolean = await this.sftpClient.exists(path);
defer.resolve(isPathExist);
This was
linked to
issues
Jul 20, 2020
sdobrodeev
force-pushed
the
users/sdobrodeev/feature13048_CopyFilesOverSSH_sftp_migration
branch
from
9298ae8 to
07a0004
Compare
sdobrodeev
force-pushed
the
users/sdobrodeev/feature13048_CopyFilesOverSSH_sftp_migration
branch
2 times, most recently
from
9792663 to
4a70555
Compare
sdobrodeev
force-pushed
the
users/sdobrodeev/feature13048_CopyFilesOverSSH_sftp_migration
branch
from
4a70555 to
402ae4b
Compare
| */ | ||
| private unixyPath(filePath) { | ||
| if (process.platform === 'win32') { | ||
| return filePath.replace(/\\/g, '/'); |
There was a problem hiding this comment.
Does it works fine with full paths like 'C:\test\etc' which can contain ":"?
damccorm
approved these changes
Jul 27, 2020
sdobrodeev
force-pushed
the
users/sdobrodeev/feature13048_CopyFilesOverSSH_sftp_migration
branch
from
402ae4b to
ed8ee28
Compare
alexander-smolyakov
approved these changes
Jul 31, 2020
Tasks/CopyFilesOverSSHV0/task.json
Outdated
| @@ -17,8 +17,8 @@ | |||
| "author": "Microsoft Corporation", | |||
| "version": { | |||
| "Major": 0, | |||
| "Minor": 172, | |||
| "Patch": 3 | |||
| "Minor": 173, | |||
There was a problem hiding this comment.
Could you please bump up task version.
sdobrodeev
force-pushed
the
users/sdobrodeev/feature13048_CopyFilesOverSSH_sftp_migration
branch
from
ed8ee28 to
05c87c6
Compare
sdobrodeev
deleted the
users/sdobrodeev/feature13048_CopyFilesOverSSH_sftp_migration
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: CopyFilesOverSSH
Description:
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N) Y
Checklist: