Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SshV0] Migrated to ssh2-sftp-client #13549

Merged
merged 4 commits into from
Sep 17, 2020
Merged

[SshV0] Migrated to ssh2-sftp-client #13549

merged 4 commits into from
Sep 17, 2020

Conversation

sdobrodeev
Copy link

@sdobrodeev sdobrodeev commented Sep 15, 2020 •
edited
Loading

Task name: SshV0

Description: Migrated from obsolete scp2 library

Documentation changes required: (Y/N) N

Added unit tests: (Y/N) N

Attached related issue: (Y/N)

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@sdobrodeev sdobrodeev requested a review from a team September 15, 2020 08:48
@sdobrodeev sdobrodeev self-assigned this Sep 15, 2020
@sdobrodeev sdobrodeev removed the request for review from zachariahcox September 15, 2020 08:48
@sdobrodeev sdobrodeev force-pushed the users/sdobrodeev/fix234_SshV0_sftp-client-migration branch from 6a5a544 to 605607f Compare September 15, 2020 11:27
anatolybolshakov
anatolybolshakov reviewed Sep 15, 2020
View reviewed changes
Tasks/SshV0/task.loc.json Outdated Show resolved Hide resolved
Tasks/SshV0/ssh2helpers.ts Outdated Show resolved Hide resolved
Tasks/SshV0/ssh2helpers.ts Outdated Show resolved Hide resolved
@anatolybolshakov anatolybolshakov requested a review from a team September 16, 2020 07:54
alexander-prozorov
alexander-prozorov approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@alexander-prozorov alexander-prozorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

alexander-smolyakov
alexander-smolyakov reviewed Sep 16, 2020
View reviewed changes
Copy link
Contributor

@alexander-smolyakov alexander-smolyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the comments, other changes LGTM.

Tasks/SshV0/ssh2helpers.ts Outdated Show resolved Hide resolved
Tasks/SshV0/ssh2helpers.ts Outdated Show resolved Hide resolved
Tasks/SshV0/ssh2helpers.ts Outdated Show resolved Hide resolved
Tasks/SshV0/ssh2helpers.ts Outdated Show resolved Hide resolved
alexander-smolyakov
alexander-smolyakov approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@alexander-smolyakov alexander-smolyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@anatolybolshakov
Copy link
Contributor

Tested with canary and other cases, going to add canary tests for SSH task

@anatolybolshakov anatolybolshakov merged commit feff6e5 into master Sep 17, 2020
@olljanat olljanat mentioned this pull request Oct 9, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-prozorov alexander-prozorov alexander-prozorov approved these changes

@alexander-smolyakov alexander-smolyakov alexander-smolyakov approved these changes

@anatolybolshakov anatolybolshakov anatolybolshakov approved these changes

Assignees

@sdobrodeev sdobrodeev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sdobrodeev @anatolybolshakov @alexander-smolyakov @alexander-prozorov