Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doNotAskAgain button for Sign In and Select Organization windows #560

Merged
merged 7 commits into from
Feb 12, 2024

Conversation

ivanduplenskikh
Copy link
Contributor

I added two new states to the state manager when user disables signing (doNotAskAgainSignIn) in and selecting organization (doNotAskAgainSelectOrg).
These states are used to store the choices when users disable the information windows for signing in and selecting an organization.

@ivanduplenskikh ivanduplenskikh requested review from a team as code owners December 7, 2023 15:40
@ivanduplenskikh ivanduplenskikh linked an issue Dec 7, 2023 that may be closed by this pull request
Copy link
Member

@winstliu winstliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this sets context, I think we want to add a new command that resets this state in case someone hits it by accident.

src/schema-association-service.ts Outdated Show resolved Hide resolved
src/schema-association-service.ts Outdated Show resolved Hide resolved
@ivanduplenskikh
Copy link
Contributor Author

Since this sets context, I think we want to add a new command that resets this state in case someone hits it by accident.

Added new command Reset state to this extension.
Reset state command sets globalState keys: DO_NOT_ASK_SIGN_IN_KEY, DO_NOT_ASK_SELECT_ORG_KEY to undefined

@winstliu
Copy link
Member

Looks like we need another review because I pushed changes...

@ivanduplenskikh
Copy link
Contributor Author

ivanduplenskikh commented Feb 12, 2024

Looks like we need another review because I pushed changes...

Thank you, LGTM.

@winstliu winstliu merged commit 956a7cb into main Feb 12, 2024
1 check passed
@winstliu winstliu deleted the users/ivanduplenskikh/554 branch February 12, 2024 15:44
@fred-gagnon
Copy link

fred-gagnon commented Feb 27, 2024

@DmitriiBobreshev Any idea when a new release of the extension will be available with this fix ? Working from an internet offline VM with a custom schema is a pain with the connection pop-up appearing every time a new file is opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable "Sign in to Azure..." notification
4 participants