You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Recently, in order to mitigate CVE-2020-1469, among other changes, line 224 of OutputBuffer class
changed from length += length >> 1; to length = checked(length + length >> 1);
This actually doesn't change the value in length variable, because the + operator precedes the bit-shift operator,
So basically we multiply and divide == no change.
This causes serious performance regression as the underlying buffer grows by single value at a time (instead of growing by half of current size)...
I'll open a PR with a fix suggestion soon.
The text was updated successfully, but these errors were encountered:
Recently, in order to mitigate CVE-2020-1469, among other changes, line 224 of OutputBuffer class
changed from
length += length >> 1;
tolength = checked(length + length >> 1);
This actually doesn't change the value in
length
variable, because the+
operator precedes the bit-shift operator,So basically we multiply and divide == no change.
This causes serious performance regression as the underlying buffer grows by single value at a time (instead of growing by half of current size)...
I'll open a PR with a fix suggestion soon.
The text was updated successfully, but these errors were encountered: