Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c#] fix Serious performance regression in Grow method of OutputBuffer #1066

Closed

Conversation

eitanhs
Copy link
Contributor

@eitanhs eitanhs commented Aug 6, 2020

fixes #1065

@chwarr chwarr closed this in 3afea82 Aug 6, 2020
@chwarr
Copy link
Member

chwarr commented Aug 6, 2020

I merged this manually to update the changelog and expand the commit message at the same time. Commit 3afea82 has been merged into master.

@eitanhs
Copy link
Contributor Author

eitanhs commented Aug 6, 2020

I merged this manually to update the changelog and expand the commit message at the same time. Commit 3afea82 has been merged into master.

Thank you!

@eitanhs eitanhs deleted the bugfix/OutputBufferRegression branch August 6, 2020 18:48
@lalo
Copy link
Member

lalo commented Aug 6, 2020

@eitanhs do you have some sort of regression tests in place? or how did you catch this so quickly?

@eitanhs
Copy link
Contributor Author

eitanhs commented Aug 6, 2020

@eitanhs do you have some sort of regression tests in place? or how did you catch this so quickly?

Sorry to disapoint, but no.. just updated to the latest version today and noticed the performance drop after manually running a tool I wrote that serializes large objects.
The issue was easy to detect since each time I stopped the debugger I noticed that it soppted at Array.Resize call, then I used github magic to compare changes between the previous release to the current and voilà :)

@lalo
Copy link
Member

lalo commented Aug 6, 2020

Great work though, for a 2 char change

@chwarr
Copy link
Member

chwarr commented Aug 6, 2020

Release 9.0.3 is live now and has this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serious performance regression in Grow method of OutputBuffer
3 participants