multiply symbols errors from: Win32Exception(const char* message)

[coinoperated0428]

Getting multiply symbol definition errors that appear to be a result of multiple includes from file:
vcpkg\installed\x64-windows\include\bond\ext\grpc\win_thread_pool.h

namespace detail
    {
        BOND_NORETURN void Win32Exception(const char* message)
        {
            throw std::system_error{
                std::error_code{ static_cast<int>(::GetLastError()), std::system_category() },
                message };
        }

    } // namespace detail

I was able to correct by adding inline specifier to the header file code definition i.e.:
inline BOND_NORETURN void Win32Exception(const char* message)

I'm i missing something fundamental here?

building bond gRPC enabled C++ native app using Visual Studio 2019 Enterprise v16.11.4 using C++17 language standard

[chwarr]

Nope, you're not missing anything. That function is indeed missing inline. Care to submit a PR with the fix?

Likely none of the Bond tests use win_thread_pool from different compilation units.

[bhardwajs]

@coinoperated0428 - I just sent a PR to fix this issue.

I think there needs to be a PR to update vcpkg port to pick up the latest changes after this is merged. https://github.com/microsoft/vcpkg/tree/master/ports/bond

[chwarr]

Thanks for the PR! Looks good to me, with two minor things.

[chwarr]

Fix merged. Thanks, @coinoperated0428 for the report and @bhardwajs for this fix.

I'm not planning to cut a release with the changes in master since 9.0.5 for a while. vcpkg can use arbitrary commits, so I don't expect this to be a problem.