Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[c++] Drop support for MSVC 2013 #851

Closed
ara-ayvazyan opened this issue Apr 13, 2018 · 2 comments
Closed

[c++] Drop support for MSVC 2013 #851

ara-ayvazyan opened this issue Apr 13, 2018 · 2 comments
Labels
enhancement

Comments

@ara-ayvazyan
Copy link
Contributor

ara-ayvazyan commented Apr 13, 2018 •
edited
Loading

The MSVC 2013 is a 4+ years old compiler with many bugs that cause a lot of trouble supporting it.
The library and generated code can be simplified and cleaned up after we drop it.
@chwarr chwarr mentioned this issue Dec 11, 2019
Closed
@bhardwajs
Copy link
Contributor

Now that #1007 is closed, can we take on deprecating MSVC 2013 support and pick up MSVC 2019?

bhardwajs added a commit to bhardwajs/bond that referenced this issue Apr 15, 2020
@bhardwajs
Remove MSVC 2013 conditional code
6395a78 
To support MSVC 2013, Bond cppcodegen generated conditional code (using

This PR cleans up cppcodegen to remove MSVC 2013 conditional code and
changes unit tests in cppcodegen correspondingly.

It also cleans up C++ and python code of MSVC 2013 conditional code.

Fixes microsoft#851
@chwarr
Copy link
Member

chwarr commented Apr 27, 2020

MSVC 2013 support has been removed. Thanks to @bhardwajs for contributing these changes!

Related commits:

@chwarr chwarr closed this as completed Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bhardwajs @chwarr @ara-ayvazyan