Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-deprecated bind/bind.hpp header #1036

Merged
merged 4 commits into from
May 18, 2020
Merged

Use non-deprecated bind/bind.hpp header #1036

merged 4 commits into from
May 18, 2020

Conversation

vaboca
Copy link
Member

@vaboca vaboca commented May 11, 2020

boost/bind.hpp is deprecated and recommends using boost/bind/bind.hpp instead, see: https://github.com/boostorg/bind/blob/develop/include/boost/bind.hpp

Copy link
Member

@chwarr chwarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a brief changelog entry to the Unreleased section, as this looks like it will fix build warnings that some people are seeing?

Overall, the change LGTM. Which Boost version first added boost::placeholders? That information will need to be included in the final commit message. (I can write it, when I have the info.)

@chwarr
Copy link
Member

chwarr commented May 12, 2020

It looks like the AppVeyor CI build is broken due to a change in the image names that AppVeyor uses. It doesn't look like this code is the cause of the break.

However, I cannot merge this change until that is fixed.
I've opened issue #1038 about this.

@chwarr
Copy link
Member

chwarr commented May 16, 2020

We got a fix for #1038. I've merged that into this PR's branch.

@chwarr
Copy link
Member

chwarr commented May 18, 2020

I've added the changelog line. This is ready for merging after the CI build finishes.

@chwarr chwarr merged commit 2e7aa1e into microsoft:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants